app-wamr: Port application to musl #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaduNichita
suggested changes
Jul 15, 2023
| OoOoO ._, ._:_:_,\_._, .__,_:_, \___) | ||
| Atlas 0.13.1~e467cdf6 | ||
| Hello world! | ||
| buf ptr: 0x400002a8 |
There was a problem hiding this comment.
Why do you have these lines in the output?
There was a problem hiding this comment.
The main.wasm file is compiled from the hello-world app-sample here, which prints these lines.
RaduNichita
suggested changes
Jul 15, 2023
R0mbertus
changed the title
|
Addressed requested changes, rebased into one file. |
R0mbertus
force-pushed
the
staging
branch
2 times, most recently
from
39796e5
to
1d6c4e5
Compare
StefanJum
requested changes
Jul 17, 2023
There was a problem hiding this comment.
Looks great @R0mbertus, please wrap you commit message to ~80 characters per line, then I'll approve it.
Added a .gitignore, Makefile and Makefile.uk along with updating the kraft.yaml to use musl and updated the README.md accordingly Signed-off-by: Robert Klink <roberthklink@gmail.com> Signed-off-by: Ricardo Mohamedhoesein <rmohamedhoesein3@gmail.com> Co-authored-by: Ricardo Mohamedhoesein <rmohamedhoesein3@gmail.com>
StefanJum
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
All good, thanks.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
RaduNichita
suggested changes
Jul 25, 2023
There was a problem hiding this comment.
All good also from my side.
Reviewed-by: Radu Nichita radunichita99@gmail.com
RaduNichita
approved these changes
Jul 25, 2023
razvand
approved these changes
Aug 5, 2023
Closed
This was referenced Sep 24, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #3 by adding the
Makefile,Makefile.ukand.gitignore, and also changes tokraft.yamland updated the `README.md.