Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base to pbase #2

Closed
wants to merge 2 commits into from
Closed

base to pbase #2

wants to merge 2 commits into from

Conversation

akouk
Copy link

@akouk akouk commented Mar 31, 2023

@akouk
base to pbase
3febcee 
Signed-off-by: akouk <kouka.anisa@gmail.com>
@razvand razvand self-requested a review April 16, 2023 09:42
@razvand razvand self-assigned this Apr 16, 2023
@razvand razvand added the enhancement New feature or request label Apr 16, 2023
razvand
razvand requested changes Apr 16, 2023
View reviewed changes
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akouk, please improve your commit message. Use full sentences, add a detailed description of the changes.

Also use your full name both as the commit author and for the Signed-off-by message.

@razvand
Copy link
Contributor

razvand commented Apr 16, 2023

@akouk, will award points for this together with the app-wamr PR.

@akouk
Update 0005-adapt-main-c-to-unikraft.patch
a2caeac 
Changing line 79:  the source of the base address for the memory region from "base" to "pbase"

Signed-off-by: Anisa Kouka <77749065+akouk@users.noreply.github.com>
@akouk akouk requested a review from razvand May 4, 2023 13:48
@mbrdg mbrdg mentioned this pull request May 11, 2023
Open
@razvand
Copy link
Contributor

razvand commented Oct 1, 2023

Closing this as it was solved by PR #8

@razvand razvand closed this Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvand razvand Awaiting requested review from razvand

Assignees

@razvand razvand

Labels
enhancement New feature or request
Projects
Hackathon Athens 2023
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akouk @razvand