feat(cloud): Add volume import partial checks #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craciunoiuc
force-pushed
the
craciunoiuc/volinit-add-checks
branch
from
e82f531
to
70a1722
Compare
craciunoiuc
force-pushed
the
craciunoiuc/volinit-add-checks
branch
from
8330adb
to
ddf4bf0
Compare
craciunoiuc
changed the title
craciunoiuc
force-pushed
the
craciunoiuc/volinit-add-checks
branch
2 times, most recently
from
50ac66e
to
1c888ed
Compare
craciunoiuc
force-pushed
the
craciunoiuc/volinit-add-checks
branch
from
1c888ed
to
3d21625
Compare
Importing is done to ensure further support is easy to do, as the library has been left mostly abandoned. The most important exposal is the raw CPIO header, needed for external processing. Although unused, it also exposes the name and entry padding for entries. Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
The following steps sum up what the new algorithm does: 1. Send the raw CPIO header -- wait for OK 2. Send the name of the file (NUL terminated) -- wait for OK 2'. Stop if last entry detected 3. Send the file content | Link destination -- wait for OK At any time the volume-import unikernel can error out and report back the error to kraftkit to forward to the user. Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
To be removed after everything is confirmed working Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
Also prints statistics at the end and queries at start. Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
craciunoiuc
force-pushed
the
craciunoiuc/volinit-add-checks
branch
from
3d21625
to
6c511b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
Merging this PR is dependent on merging the counterpart from @smoga on volume importing.
It is also dependent on removing feat(cloud): Introduce debug code after testing of course.
It is also dependent on adding support for prompts in processes.