patches: Add syscall function prototype #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `sys/syscall.h` header is missing a declaration for the `syscall()` function, which may lead to `implicit declaration` warnings that could be treated as errors (i.e. by the GO runtime) We also include Unikraft's `syscall_nrs2.h` header which provides definitions for the `__NR_` macros needed by some libraries. Signed-off-by: Eduard Vintilă <eduard.vintila47@gmail.com>
This was referenced Jul 26, 2023
StefanJum
approved these changes
Aug 6, 2023
There was a problem hiding this comment.
All good, thanks.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
razvand
approved these changes
Aug 6, 2023
There was a problem hiding this comment.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
RaduNichita
approved these changes
Aug 6, 2023
There was a problem hiding this comment.
All good also from my side.
Reviewed-by: Radu Nichita radunichita99@gmail.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sys/syscall.hheader is missing a declaration for thesyscall()function, which may lead toimplicit declarationwarnings that could be treated as errors (i.e. by the GO runtime)We also include Unikraft's
syscall_nrs2.hheader which provides definitions for the__NR_macros needed by some libraries.This PR is part of a series of PRs that work in conjunction for the update of Go support to 1.18:
For testing, make sure to pass to QEMU the
-cpu hostargument (this is necessary because the paging API and ukvmem are required bylibgoas part of Virtual Address space management, and somehow the default CPU just won't handle 1GB pages).Only GCC12 and x86 is supported for the moment.