Add Makefile and update Makefile.uk #9
Conversation
There was a problem hiding this comment.
It works on my side, many thanks @eduardvintila 
I left two questions more out of curiosity, I will approve after receiving your input of those.
Makefile
Outdated
| UK_ROOT ?= $(PWD)/.unikraft/unikraft | ||
| UK_LIBS ?= $(PWD)/.unikraft/libs | ||
|
|
||
| LIBS-y := |
There was a problem hiding this comment.
Why did you put the libraries like so and not on the same line?
There was a problem hiding this comment.
No particular reason, it was easier to remove and add libraries that way 😆
| @@ -1,3 +1,3 @@ | |||
| $(eval $(call addlib,apphelloworldgo)) | |||
| $(eval $(call addgoapp,apphelloworldgo)) | |||
There was a problem hiding this comment.
Because libgo has custom build mechanics, given by this PR from Unikraft core and this rule from libgo
There was a problem hiding this comment.
@eduardvintila looks good, few comments:
- Use
LIBSinstead ofLIBS-y, in order to be consistent with other applications. - State why changing the
addlibrule toaddgoappwas necessary in the commit description.
eduardvintila
force-pushed
the
go-update
branch
from
f519486
to
928e542
Compare
Golang applications which use the `libgo` external library have custom build mechanics, where the `addlib` rule is replaced by either `addgolib` (for GO packages used as libraries), or `addgoapp`. In this case, we need to call the `addgoapp` Makefile rule to indicate that we're building a GO app which provides the main function. Signed-off-by: Eduard Vintilă <eduard.vintila47@gmail.com>
Signed-off-by: Eduard Vintilă <eduard.vintila47@gmail.com>
eduardvintila
force-pushed
the
go-update
branch
from
928e542
to
1c31909
Compare
|
@StefanJum I've added an explanation and replaced |
There was a problem hiding this comment.
All good with me now.
Reviewed-by: Radu Nichita radunichita99@gmail.com
There was a problem hiding this comment.
All good, thanks.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
Signed-off-by: Eduard Vintilă <eduard.vintila47@gmail.com> Reviewed-by: Radu Nichita <radunichita99@gmail.com> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #9
This PR is part of a series of PRs that work in conjunction for the update of Go support to 1.18:
For testing, make sure to pass to QEMU the
-cpu hostargument (this is necessary because the paging API and ukvmem are required bylibgoas part of Virtual Address space management, and somehow the default CPU just won't handle 1GB pages).Only GCC12 and x86 is supported for the moment.