Allow deselection of ukmmap #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @marcrittinghaus, this works on my side. I'll approve it after @eduardvintila's review. |
|
@marcrittinghaus, would it make sense to prefix the commit message with |
eduardvintila
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Thanks, Marc. Looks good!
Reviewed-by: Eduard Vintilă eduard.vintila47@gmail.com
With posix-mmap we have an alternative implementation of the memory management functions such as mmap, mprotect, etc. To be able to select posix-mmap, we must deselect ukmmap. Thus, this commit removes the hard dependency. Signed-off-by: Marc Rittinghaus <marc.rittinghaus@unikraft.io>
marcrittinghaus
force-pushed
the
mritting/pr_imply_ukmmap
branch
from
49504e0
to
17da8b4
Compare
|
@razvand I updated the commit message. |
razvand
approved these changes
Jul 14, 2023
This was referenced Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With posix-mmap we have an alternative implementation of the memory management functions such as mmap, mprotect, etc. To be able to select posix-mmap, we must deselect ukmmap. Thus, this commit removes the hard dependency.