plat/common: Increase granularity of hardcoded legacy high memory #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogasergiu
force-pushed
the
smoga/legacy_hi_mem_gran++
branch
from
aa58500
to
d23ea00
Compare
unikraft-bot
added
area/plat
razvand
requested review from
mschlumpp and
michpappas
and removed request for
a team and
dragosargint
mogasergiu
added a commit
to mogasergiu/unikraft
that referenced
this pull request
Aug 15, 2023
4 tasks
mschlumpp
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Seems to work in all configurations I tested (QEMU/Firecracker).
Reviewed-by: Marco Schlumpp marco@unikraft.io
To ensure compatibility with boot protocols that do report the BIOS System Memory region as a reserved region, split the memory region inserted by `ukplat_memregion_list_insert_legacy_hi_mem` into two memory region descriptors: one to contain known memory holes (e.g. VGA Text Mode framebuffer) and one to contain the previously mentioned BIOS System Memory region. The former will have read/write permissions to ensure that zones like the VGA framebuffer or certain PCI BARs mapped by the BIOS are writable, while the latter will only have read permissions to ensure compatibility with other boot protocols. Signed-off-by: Sergiu Moga <sergiu@unikraft.io>
mogasergiu
force-pushed
the
smoga/legacy_hi_mem_gran++
branch
from
d23ea00
to
b77dbd9
Compare
4 tasks
|
✅ Checkpatch passed Beep boop! I ran Unikraft's
|
michpappas
approved these changes
Aug 15, 2023
razvand
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure compatibility with boot protocols that do report the BIOS System Memory region as a reserved region, split the memory region inserted by
ukplat_memregion_list_insert_legacy_hi_meminto two memory region descriptors: one to contain known memory holes (e.g. VGA Text Mode framebuffer) and one to contain the previously mentioned BIOS System Memory region. The former will have read/write permissions to ensure that zones like the VGA framebuffer or certain PCI BARs mapped by the BIOS are writable, while the latter will only have read permissions to ensure compatibility with other boot protocols.Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
x86_64or N/A]kvm,xenor N/A]app-python3or N/A]Additional configuration
Description of changes