Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExtensionDtype path should follow documentation #915

Merged
merged 1 commit into from
Aug 15, 2022
Merged

ExtensionDtype path should follow documentation #915

merged 1 commit into from
Aug 15, 2022

Commits on Aug 14, 2022

  1. ExtensionDtype path should follow documentation 

    Since at least `pandas==1.2.0`, one can access `ExtensionDtype` via `pandas.api.extensions`. See: https://github.com/pandas-dev/pandas/blob/3e89b4c4b1580aa890023fc550774e63d499da25/pandas/api/extensions/__init__.py#L19

This is what `pandas` has on their documentation: https://pandas.pydata.org/docs/reference/api/pandas.api.extensions.ExtensionDtype.html#pandas.api.extensions.ExtensionDtype

Moreover, as of at least `pandas==1.4.3`, importing from `pandas.core` will no long satisfy static type checkers: 
https://github.com/pandas-dev/pandas/blob/96fe05979c13ef4575faaf65c673016e3432c175/pandas/__init__.py
    @pepelovesvim
    pepelovesvim committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    afb1587 View commit details
    Browse the repository at this point in the history