ExtensionDtype path should follow documentation
#915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since at least `pandas==1.2.0`, one can access `ExtensionDtype` via `pandas.api.extensions`. See: https://github.com/pandas-dev/pandas/blob/3e89b4c4b1580aa890023fc550774e63d499da25/pandas/api/extensions/__init__.py#L19 This is what `pandas` has on their documentation: https://pandas.pydata.org/docs/reference/api/pandas.api.extensions.ExtensionDtype.html#pandas.api.extensions.ExtensionDtype Moreover, as of at least `pandas==1.4.3`, importing from `pandas.core` will no long satisfy static type checkers: https://github.com/pandas-dev/pandas/blob/96fe05979c13ef4575faaf65c673016e3432c175/pandas/__init__.py
Codecov Report
@@ Coverage Diff @@
## master #915 +/- ##
=======================================
Coverage 97.39% 97.39%
=======================================
Files 43 43
Lines 4179 4179
=======================================
Hits 4070 4070
Misses 109 109
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cosmicBboy
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since at least
pandas==1.2.0, one can accessExtensionDtypeviapandas.api.extensions. See here. This is whatpandashas on their documentation. Moreover, as of at leastpandas==1.4.3, importing frompandas.corewill no long satisfy static type checkers.