Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to JSDOM@11 #5

Closed
unional opened this issue Jul 23, 2017 · 2 comments
Closed

Upgrade to JSDOM@11 #5

unional opened this issue Jul 23, 2017 · 2 comments
Labels
help wanted

Comments

@unional
Copy link
Owner

unional commented Jul 23, 2017

No description provided.

@unional unional changed the title Upgrade to JSDOM@2 Upgrade to JSDOM@11 Jul 23, 2017
@unional
Copy link
Owner Author

unional commented Oct 1, 2017

The new JSDOM has limited features comparing to 9 and below.
It does not provide API to load scripts.
We have to load scripts by composing script tags.

One alternative is to load all scripts using systemjs.
There are two questions related to that approach:

  1. Will systemjs choke up on a certain script?
  2. Performance issue.

For (1), it should be ok as all scripts currently loaded by JSDOM are just global scripts and should be able to load by systemjs.
For (2), need to see the actual before to decide.

One good thing on this approach it that it would likely be easier to add hook to systemjs to support code coverage as needed in istanbuljs/nyc#529

@unional
Copy link
Owner Author

unional commented Oct 1, 2017

Fixed by #7

@unional unional closed this as completed Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@unional