Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP Selection Ranges #4256

Draft
wants to merge 1,865 commits into
base: trunk
Choose a base branch
from
Draft

LSP Selection Ranges #4256

wants to merge 1,865 commits into from
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Jul 2, 2024

  1. Configuration menu
    Copy the full SHA
    6ae9f8b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eaf233c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fdf91bb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e9f2aa3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2331c16 View commit details
    Browse the repository at this point in the history
  6. Merge trunk

    ChrisPenner committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    cc07b63 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1d5ae81 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    92a74df View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    54e17f2 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a74d4e8 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Configuration menu
    Copy the full SHA
    06b731b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    052fd51 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1857640 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    05d3402 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8ff7e6d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1dab376 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a7820fe View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7148685 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7f57612 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2db50ad View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    31874bd View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    8a405e0 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Configuration menu
    Copy the full SHA
    38a73da View commit details
    Browse the repository at this point in the history
  2. switch Left to Right on help outputs; add draft transcripts (#1)

    Maybe some duplication/conflicts here unintentionally.
    
    The big transcript is just a WIP, we could make it prettier.
    sellout committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    39179a3 View commit details
    Browse the repository at this point in the history
  3. move pretty-print helpers out of CommandLine.hs

    to avoid a potential cycle between CommandLine.hs and InputPatterns.hs
    that otherwise came up on another branch.
    
    InputPatterns.hs also has formatting helpers that could be used in CommandLine.hs.
    Maybe they should be moved too, but I haven't thought about it.
    aryairani committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    4bbbc8c View commit details
    Browse the repository at this point in the history
  4. Fix shared CLI error message

    - don’t add an extra indent level to the entire output
    - do add a `warnCallout` to the message
    - don’t re-wrap formatted error output
    - remove the accidentally-included entire `help <command>` output
    sellout committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    111fc5e View commit details
    Browse the repository at this point in the history
  5. Make CLI error messages more consistent

    - remove `warnCallout` and `warn` from individual messages
    - make sure no error messages return their `help` content
    - add some documentation about how to write failure messages
    sellout committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    67399e9 View commit details
    Browse the repository at this point in the history
  6. Fix formatting of an error message

    It was leaving out spaces between literal text and generated text.
    sellout committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    41a0da8 View commit details
    Browse the repository at this point in the history
  7. Update transcript outputs

    sellout committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    a7f1c24 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0e76597 View commit details
    Browse the repository at this point in the history
  9. Remove a help message from an error

    This silpped by in the merge.
    sellout committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    81f9458 View commit details
    Browse the repository at this point in the history
  10. Remove another warning flag from a message

    Another one missed in the merge.
    sellout committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    ddbfb35 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    deaf355 View commit details
    Browse the repository at this point in the history
  12. change a punctuation

    aryairani committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    8be432b View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    2b60344 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    c773017 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    b9f4bfe View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    293b4a2 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    6a6c4d6 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    25db6fb View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    e102b0d View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    61287bd View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    a6b8af1 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    222bd48 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    0331d22 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    0587dde View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    dd17539 View commit details
    Browse the repository at this point in the history
  26. Merge trunk

    ChrisPenner committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    49258bc View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2024

  1. Configuration menu
    Copy the full SHA
    dd81f0a View commit details
    Browse the repository at this point in the history
  2. Rerun transcripts

    ChrisPenner committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    4c89423 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d0002b4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    424b43b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6021a3a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    927b76b View commit details
    Browse the repository at this point in the history
  7. Fix integration-tests

    ChrisPenner committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    c431d35 View commit details
    Browse the repository at this point in the history
  8. Fix up round-trip tests

    ChrisPenner committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    69edcef View commit details
    Browse the repository at this point in the history
  9. Merge pull request #5188 from unisonweb/lsp/unused-binding-detection

    Unused binding detection cleanup
    ChrisPenner committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    60bb91a View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    ecf5fe1 View commit details
    Browse the repository at this point in the history
  11. avoid numeric vs textual clash in args length error

    `numerals` doesn't seem to be maintained anymore, however
    aryairani committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    b14931f View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Configuration menu
    Copy the full SHA
    0cea9d6 View commit details
    Browse the repository at this point in the history
  2. Improve docs

    ChrisPenner committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    5e775cc View commit details
    Browse the repository at this point in the history
  3. Add undo.md transcript

    ChrisPenner committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    c625e47 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Configuration menu
    Copy the full SHA
    da449fb View commit details
    Browse the repository at this point in the history
  2. synhash var bugfix: hash debruijn indexes, not var names

    also adds a debug.synhash.term command for debugging
    mitchellwrosen committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    9cc6c2b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d70b219 View commit details
    Browse the repository at this point in the history
  4. delete unused import

    mitchellwrosen committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    701f308 View commit details
    Browse the repository at this point in the history
  5. Update unison-cli/src/Unison/CommandLine/InputPatterns.hs

    Co-authored-by: Greg Pfeil <greg@technomadic.org>
    aryairani and sellout committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    22d4b26 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ee6793b View commit details
    Browse the repository at this point in the history
  7. add transcript

    mitchellwrosen committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    94c6bfc View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    223df40 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    615887f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2c1a048 View commit details
    Browse the repository at this point in the history
  11. Pin Haskell tool versions for VS Code

    This also has the flake get its version pins (when possible) from the VS
    Code settings. And we pin Cabal now, too.
    sellout committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    c3405c2 View commit details
    Browse the repository at this point in the history
  12. Ignore more scratchfiles

    ChrisPenner committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    66d9b76 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    e506b00 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    d8e34c2 View commit details
    Browse the repository at this point in the history
  15. Merge pull request #5195 from unisonweb/force-highlighting

    Use `SyntaxText.Unit` as style for `foo()`
    pchiusano committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    2591ade View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    4254a51 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    c156ba7 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    6fe6d67 View commit details
    Browse the repository at this point in the history
  19. adjust some output

    mitchellwrosen committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    1e5b925 View commit details
    Browse the repository at this point in the history
  20. Merge trunk

    ChrisPenner committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    736ccf1 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    951f318 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    d78154d View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Fix test build

    ChrisPenner committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    09ecc74 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1543160 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9b11d96 View commit details
    Browse the repository at this point in the history
  4. Docs and transcripts

    ChrisPenner committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    67a41cd View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1cd3f3c View commit details
    Browse the repository at this point in the history
  6. Fix merge transcript

    ChrisPenner committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    fa6c59e View commit details
    Browse the repository at this point in the history
  7. Fix names transcript

    ChrisPenner committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    f725bf2 View commit details
    Browse the repository at this point in the history
  8. Replace transcript parser with cmark

    We don’t need a very rich parser for transcripts, but we _do_ need to
    reliably identify fenced code blocks, and that implies a number of
    subtle cases. Using a polished CommonMark parser/printer handles those
    subtleties for us.
    
    I chose `cmark` for a few reasons:
    - it’s a wrapper around `libcmark`, which is the reference
      implementation of CommonMark, so it should be correct;
    - it provides both a parser and a printer (unlike MMark); and
    - it is extremely fast (about 20x faster than MMark), so the fact that
      our home-rolled parser got to skip over everything that’s not a block
      isn’t an issue.).
    
    This only _partially_ uses the `cmark` printer. I think it should use it
    entirely, but for the cases where we do streaming output (processing UCM
    commands, etc.) it’s a more involved change. So I think it should be
    handled separately.
    sellout committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    9e2fa2b View commit details
    Browse the repository at this point in the history
  9. Update the transcripts with cmark

    `cmark`’s pretty-printer matches our output pretty well, with a few differences:
    - it puts a space between the fence and the info string for in code blocks;
    - it prefers `-` over `*` for bulleted lists (as do I) and it indents them;
    - it `\`-escapes certain chars very conservatively;
    - it prefers indented/unfenced code blocks if there is no info string; and
    - it prefers `*` over `_` (unlike any sane person).
    
    This also shows how the change fixes a number of issues:
    - fix2158-1.output.md also illustrates how this change fixes #1809;
    - alias-many.output.md and input-parse-errors.output.md show how fenced
      code blocks without an info string would use the beginning of the
      content as the info string;
    - transcripts-round-trip/main.output.md shows how output blocks for
      generated `unison` stanzas (which could contain nested fenced blocks)
      might not have long-enough fences; and
    - error-messages.output.md and generic-parse-errors.output.md show how
      Unison errors were reported on the wrong line number (and thus the
      printed error lines were also incorrect).
    sellout committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    1dc181b View commit details
    Browse the repository at this point in the history
  10. Add a space before code block info strings

    This is for consistency with the `cmark` style. Now the blocks we still
    pretty-print ourselves will match the bulk of them that `cmark`
    produces.
    sellout committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    0031542 View commit details
    Browse the repository at this point in the history
  11. Fix a few transcripts with incorrect Markdown

    These weren’t errors in any way, but the `cmark`-produced outputs made
    it clear that some of our transcripts weren’t formatted the way we
    intended.
    sellout committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    b657d0d View commit details
    Browse the repository at this point in the history
  12. Add transcripts for fixed issues

    This shows that this change fixes #1421, #2826, #5141, and #5168.
    sellout committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    8416708 View commit details
    Browse the repository at this point in the history
  13. Terminate API code blocks correctly

    They were missing trailing newlines, so as you can see in the diff, some
    transcripts had invalid output.
    sellout committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    179b8d1 View commit details
    Browse the repository at this point in the history
  14. Typo

    ChrisPenner committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    bf20459 View commit details
    Browse the repository at this point in the history
  15. Fix Upgrade

    ChrisPenner committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    2f4e57d View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    bf44246 View commit details
    Browse the repository at this point in the history
  17. Update a couple transcripts to the new formatting

    These aren‘t run as part of ./scripts/check.sh, so they got missed in the initial pass.
    sellout committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    cbd533e View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    f382ef1 View commit details
    Browse the repository at this point in the history
  19. No leading dot on brps

    ChrisPenner committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    a455180 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Configuration menu
    Copy the full SHA
    a4b67cd View commit details
    Browse the repository at this point in the history
  2. Merge branch 'trunk' into cp/project-root

    # Conflicts:
    #	unison-cli-integration/integration-tests/IntegrationTests/transcript.output.md
    #	unison-src/transcripts-round-trip/main.output.md
    #	unison-src/transcripts/add-run.output.md
    #	unison-src/transcripts/bug-strange-closure.output.md
    #	unison-src/transcripts/cycle-update-5.output.md
    #	unison-src/transcripts/delete.output.md
    #	unison-src/transcripts/diff-namespace.output.md
    #	unison-src/transcripts/move-namespace.output.md
    #	unison-src/transcripts/name-selection.output.md
    #	unison-src/transcripts/names.output.md
    #	unison-src/transcripts/namespace-dependencies.output.md
    #	unison-src/transcripts/propagate.output.md
    #	unison-src/transcripts/reflog.output.md
    #	unison-src/transcripts/reset.output.md
    #	unison-src/transcripts/tab-completion.output.md
    #	unison-src/transcripts/transcript-parser-commands.output.md
    aryairani committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    0cd3cd1 View commit details
    Browse the repository at this point in the history
  3. Remerge remote

    ChrisPenner committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    7113005 View commit details
    Browse the repository at this point in the history
  4. Merge trunk

    ChrisPenner committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    4045805 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c2958cc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    987cd61 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    474fddb View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1e4f1ab View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    670b086 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    60596a2 View commit details
    Browse the repository at this point in the history
  11. Merge pull request #5041 from unisonweb/cp/project-root

    Project Roots
    mergify[bot] committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    be7e6cb View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Use builtin reference names in foreign decompiling

    E.G. print <Promise> instead of <Foreign>
    dolio committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    a010a8a View commit details
    Browse the repository at this point in the history
  2. Merge pull request #5216 from unisonweb/topic/decomp-foreign

    Use builtin reference names in foreign decompiling
    mergify[bot] committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    212a232 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5652c17 View commit details
    Browse the repository at this point in the history
  4. Merge trunk

    ChrisPenner committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    7c52443 View commit details
    Browse the repository at this point in the history
  5. Add unused binding test

    ChrisPenner committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    11208f5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    df0261c View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. Configuration menu
    Copy the full SHA
    0dc7b6d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    264a31a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ce5c9fe View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Configuration menu
    Copy the full SHA
    0c7851d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ed06f3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    456b8e6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9516c59 View commit details
    Browse the repository at this point in the history
  5. update transcripts

    neduard committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    4e44b94 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ba78b69 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b65836b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7019595 View commit details
    Browse the repository at this point in the history
  9. Avoid duplicating YAML info in Markdown

    Reviewing the last merge into #5142, I noticed some duplicated and out-
    of-date information. This brings things up-to-date and slightly reduces
    the duplication.
    
    - bumped Ormolu used by ci.yaml from 0.5.2.0 to 0.7.2.0, to match
      flake.nix
    - removed Markdown that claimed ci.yaml was using Ormolu 0.5.0.1
    - moved description from `base-codebase` in Markdown to comment on
     `runtime_tests_codebase` in ci.yaml (and updated it to refer to
       builtin-tests/interpreter-tests.md instead of builtin-tests/base.md)
    - removed `unison_src_test_results` as it’s no longer managed as a
      single variable
    - moved other comments from Markdown to ci.yaml
    - added Markdown recommending to look in ci.yaml for specifics
    - rearranges the order of vars in ci.yaml to match the order they were
      presented in Markdown
    
    One thing I wasn’t sure how to map over: Markdown claims Racket 8.7 is
    used in CI, but ci.yaml doesn’t mention any Racket version.
    sellout committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    960f7d1 View commit details
    Browse the repository at this point in the history
  10. Don’t let Stack tell contributors to upgrade

    We use a specific version of Stack, we don’t want Stack complaining to
    contributors that it doesn’t happen to be the latest.
    sellout committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    f919c9b View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    605e062 View commit details
    Browse the repository at this point in the history
  12. Don’t let Stack complain about Nix

    We intentionally disable Stack’s Nix integration when it’s run from a
    Nix shell. We don’t want Stack complaining that we should enable it
    since it found `nix` on the path.
    sellout committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    e108014 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Configuration menu
    Copy the full SHA
    4538189 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1337ac2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    525e923 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a406431 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f17af1f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ce9b1d8 View commit details
    Browse the repository at this point in the history
  7. Minor formatting cleanup

    So my editor stops fixing things for me.
    sellout committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    734b6c4 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Refactoring TranscriptParser

    A bunch of small changes in TranscriptParser
    
    - remove dead code
    - don’t use `Show` for formatted output
    - put processed blocks in a separate sum type from unprocessed blocks
    - remove `Transcript` from identifiers (changed importers to use
     `qualified as Transcript`)
    - deduplicated some error reporting
    
    And one happy fix, IMO – got rid of the `Text.init` that plagued me in
    sellout committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    00f6c8c View commit details
    Browse the repository at this point in the history
  2. Split TranscriptParser into three modules

    - `Transcript` – the data model
    - `Transcript.Parser` – the parser and printer
    - `Transcript.Runner` – the runner
    
    There is unfortunately still some printing tightly coupled to the
    runner, but this makes it more obvious. Also, the runner is the only
    component tied to the CLI.
    sellout committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    b1cf123 View commit details
    Browse the repository at this point in the history
  3. Clean up devShell definition

    Mostly formatting, but also
    - removes Apple’s Cocoa from the dependencies,
    - moves some dependencies from `buildInputs` to `nativeBuildInputs`.
    sellout committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    bf080a5 View commit details
    Browse the repository at this point in the history
  4. Add cachix to the devShell

    This tool manages the Unison cache, so it’s useful to provide in dev
    environments. Actually pushing to the cache requires a secret key.
    sellout committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    f189432 View commit details
    Browse the repository at this point in the history
  5. Merge trunk

    ChrisPenner committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    b0be480 View commit details
    Browse the repository at this point in the history
  6. automatically run ormolu

    ChrisPenner authored and github-actions[bot] committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    cdab05d View commit details
    Browse the repository at this point in the history
  7. use libb2 for all blake functions

    required if compiling on systems that use eg libressl
    neduard committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e3b2e4b View commit details
    Browse the repository at this point in the history
  8. use /usr/bin/env sh for jit-tests.sh

    this is more portable and ensures we can compile on systems without bash (eg *BSD)
    neduard committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    f18cb2f View commit details
    Browse the repository at this point in the history
  9. just whitespace changes

    neduard committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    d66c5c7 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b6b3137 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3cd2a76 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    05362b8 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    55560e5 View commit details
    Browse the repository at this point in the history
  14. minor fixups

    neduard committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    7ed45f6 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    c657e58 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Merge pull request #5237 from neduard/jit-support-non-gnu-unix-systems

    Support native compilation on non-GNU Unix systems
    mergify[bot] committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    42ebc76 View commit details
    Browse the repository at this point in the history
  2. Run Ormolu over the entire codebase

    With #5142, Ormolu was upgraded from 0.5.2.0 to 0.7.2.0. This formats
    the codebase to avoid spurious formatting comingled in other commits.
    
    Almost all of the changes are simply wrapping single constraints in parens, like
    ```diff
    -hashBranch :: forall m. Monad m => Branch m -> m BranchHash
    +hashBranch :: forall m. (Monad m) => Branch m -> m BranchHash
    ```
    
    There is also some reordering of language pragmas and imports,
    indentation correction (some of which gets precedence wrong), and switching
    some Haddock from `-- ^` to `-- |` .
    sellout committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    b8f1ed9 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Manually reformat chains of single constraints

    Changing `(A x) => (B y) => x -> y` to `(A x, B y) => x -> y`.
    sellout committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    f7633ce View commit details
    Browse the repository at this point in the history
  2. Inform Ormolu of some operator precedences

    This adds a .ormolu file to tell Ormolu what some operator precedences
    are, to improve indentation of multi-line operator sequences.
    sellout committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    9ac6a04 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    01b475c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2cf03fe View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8e469ad View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ef62cd9 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    677266d View commit details
    Browse the repository at this point in the history
  8. fix jit generation in ci.yaml

    neduard committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    6ede3fc View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Don't limit max line length on .u scratch files

    The recently added `.editorconfig` sets a max line length of 120 characters for all file types. I found this to be
    pretty frustrating when writing Unison scratch files. While writing Unison code my editor would seemingly randomly
    create a new line, generating invalid Unison code. This came up more often when writing `Doc` values, since I tend to
    write longer lines in prose than in code.
    
    The formatting in scratch files is ephemeral, so I don't think that there is any good reason to force a max line length
    on it.
    ceedubs committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    4584e1f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0582617 View commit details
    Browse the repository at this point in the history
  3. automatically run ormolu

    ChrisPenner authored and github-actions[bot] committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    6e6c0ab View commit details
    Browse the repository at this point in the history
  4. Update transcripts

    ChrisPenner committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    5bedaf3 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #5243 from unisonweb/cp/remove-reset-root

    Remove reset-root, fix docs for reset
    aryairani committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    c4fc8d4 View commit details
    Browse the repository at this point in the history
  6. branch.reflog -> reflog

    ChrisPenner committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    1b22343 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6ff07ff View commit details
    Browse the repository at this point in the history
  8. update work

    mitchellwrosen committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    c7a55f0 View commit details
    Browse the repository at this point in the history
  9. Merge pull request #5244 from unisonweb/cp/reflog-name

    branch.reflog -> reflog
    ChrisPenner committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    7301b69 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. simplify update

    mitchellwrosen committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    4b68359 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7506ae2 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. move some code around

    mitchellwrosen committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    7c307e6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e64ffb6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aea1660 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #5242 from unisonweb/editor-config-u

    Don't limit max line length on .u scratch files
    ceedubs committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    caf58fa View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    032e360 View commit details
    Browse the repository at this point in the history
  6. Ensure transcript parser consumes entire stanzas

    With the switch to `cmark`, the “second phase” parsing of individual
    stanzas omitted an EOF check to ensure that the entire stanza had been
    parsed. This resulted in parses where we end up with truncated sets of
    UCM commands or API requests, which could either result in premature
    success or failures occurring later in the transcript, where they’d
    complain about the wrong thing.
    sellout committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    bd4c204 View commit details
    Browse the repository at this point in the history
  7. Add transcripts for some already-fixed issues

    This fixes #1327 (which was actually fixed by #5056 or #5061) and #3977
    was already closed, but without the transcript to avoid regression.
    sellout committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    80143eb View commit details
    Browse the repository at this point in the history
  8. delete unused imports

    mitchellwrosen committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    c4c2327 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Configuration menu
    Copy the full SHA
    59f41c6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    04c659d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f59c428 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b12baa4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0079f2a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    daa97fd View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    17c6c8e View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Configuration menu
    Copy the full SHA
    a49146f View commit details
    Browse the repository at this point in the history
  2. Merge pull request #5254 from unisonweb/cp/defn-search-sync

    Add FromJSON for Display Object for definition search
    aryairani committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    f559576 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. Configuration menu
    Copy the full SHA
    21209e2 View commit details
    Browse the repository at this point in the history
  2. Separate the Doc lexer from the Unison lexer

    `doc2` is a Unison lexer that traverses a `Doc`.
    
    `docBody` is the actual `Doc` lexer that is ignorant of the fact that Unison wraps `Doc` blocks in `{{`/`}}`.
    sellout committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    d1fe6d9 View commit details
    Browse the repository at this point in the history
  3. Move the Annotated class to the Ann module

    This is in preparation for using `Ann` in the `Lexer` module, as that module
    actually does some parsing.
    sellout committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    543daa3 View commit details
    Browse the repository at this point in the history
  4. Un-hiding the Doc parser

    `doc2` was a parser in lexer’s clothing. It would parse recursively, but
    then return the result as a flat list of tokens.
    
    This separates the parsing from the “unparsing” (which returns the
    tokens), so now we have a parser to a recursive `Doc` structure. This
    currently immediately applies the unparser, and should result in an
    identical stream of tokens as the previous version. Eventually, we
    should be able to avoid unparsing the `Doc` structure.
    sellout committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    5f87b41 View commit details
    Browse the repository at this point in the history
  5. Don’t “un-parse” Doc.

    This removes the layer that makes the `Doc` parser look like a lexer and
    replaces it with a function that converts the Doc structure directly
    Unison Terms.
    sellout committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    227ff27 View commit details
    Browse the repository at this point in the history
  6. Extract preParse from lexer

    After running the core of the lexer, the `lexer` function then does some
    work to turn the stream into a tree, and reorder some lexemes. It then
    throws away the tree structure.
    
    This is the first step of preserving the tree structure for the parser.
    It extracts the “pre-parser” from `lexer` so
    that it can eventually be used _after_ the lexer, rather than internally.
    
    This also moves `fixup` to be applied on each block as we reorder it,
    rather than across the entire stream at the end (since the goal is to
    not _have_ an entire stream any more).
    sellout committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    159ea3a View commit details
    Browse the repository at this point in the history
  7. Allow EOF to close layout blocks

    This removes the need to pad the lexer stream with trailing `Close` lexemes. If
    EOF is reached, the parser will automatically close any layout blocks (but not
    context-free blocks).
    sellout committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    32472bd View commit details
    Browse the repository at this point in the history
  8. Make comments into Haddock

    sellout committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    94065e0 View commit details
    Browse the repository at this point in the history
  9. Expose preParse to the parser

    sellout committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    567238f View commit details
    Browse the repository at this point in the history
  10. Rename T to BlockTree

    sellout committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    6c561f3 View commit details
    Browse the repository at this point in the history
  11. Restructure BlockTree

    We now build the stanzas at the same time as the tree, and don’t discard them after reordering.
    
    This also changes the closing element of `Block` to be `Maybe` instead of `[]`.
    sellout committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    3158e66 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    a6f6d9c View commit details
    Browse the repository at this point in the history
  13. Split Doc into its own module

    sellout committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    c53cb08 View commit details
    Browse the repository at this point in the history
  14. Add Data.Functor.Classes instances

    These are needed for the new Doc types, but had been stubbed out. Moving
    the Doc types to their own module forced the changes that got in the way
    of generating these with Template Haskell.
    sellout committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    70fe615 View commit details
    Browse the repository at this point in the history
  15. Simplify restoreStack

    It’s only used inside `local`, so its attempts to restore the layout are for naught.
    sellout committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    31f9522 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    6f2d188 View commit details
    Browse the repository at this point in the history
  17. Split the Doc parser into multiple functions

    In general, they map to the constructors of the Doc types, with some wiggle room for now.
    
    It’s probably beneficial to review this commit by ignoring whitespace.
    sellout committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    e9512a6 View commit details
    Browse the repository at this point in the history
  18. Generalize the Doc parser

    It is now completely[^1] independent of the Unison language. The parser takes a few parsers as arguments: one for
    identifiers, one for code, and one to indicate the end of the Doc block.
    
    [^1]: There is one last bit to be removed in the next commit – Doc still looks for `type` or `ability` to identify type
    links.
    sellout committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    a6528ac View commit details
    Browse the repository at this point in the history
  19. Caught a hardcoded }} in the Doc parser

    The Doc parser shouldn’t know how Unison terminates Doc blocks.
    sellout committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    9a941a3 View commit details
    Browse the repository at this point in the history
  20. Make Doc parser ignorant of type/term distinctions

    This was the last thing tying Doc to Unison.
    sellout committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    beecaa9 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Configuration menu
    Copy the full SHA
    3df6418 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    43bfa09 View commit details
    Browse the repository at this point in the history
  3. permit empty matches

    tstat committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    94209ea View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. remove unused arg

    tstat committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    72da81f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4acebf0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9e4719e View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Configuration menu
    Copy the full SHA
    03b225c View commit details
    Browse the repository at this point in the history
  2. re-add names.global

    ChrisPenner committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    d4a04b7 View commit details
    Browse the repository at this point in the history
  3. Rerun transcripts

    ChrisPenner committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    e545e0b View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Fix transcripts

    ChrisPenner committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    f9db384 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8c9c3ba View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4803d44 View commit details
    Browse the repository at this point in the history
  4. tweak output messages

    aryairani committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    9100b97 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8a3e2ef View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Configuration menu
    Copy the full SHA
    c5a66d5 View commit details
    Browse the repository at this point in the history
  2. Add a transcript showing that #5076 was fixed

    Some handling of blocks without final newlines was improved in the course of this PR.
    
    Fixes #5076.
    sellout committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    96f865b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1ee188d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d184ac1 View commit details
    Browse the repository at this point in the history
  5. debug nix-dev-cache

    aryairani committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    ac75905 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3e87dc3 View commit details
    Browse the repository at this point in the history
  7. Update nix-dev-cache.yaml

    aryairani committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    a26a31a View commit details
    Browse the repository at this point in the history
  8. Update nix-dev-cache.yaml

    aryairani committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    d12176f View commit details
    Browse the repository at this point in the history
  9. Update nix-dev-cache.yaml

    aryairani committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    d903fd2 View commit details
    Browse the repository at this point in the history
  10. Update .github/workflows/nix-dev-cache.yaml

    Co-authored-by: Greg Pfeil <greg@technomadic.org>
    aryairani and sellout committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    02f9eb7 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    d7ac7c6 View commit details
    Browse the repository at this point in the history
  12. Merge pull request #5265 from unisonweb/lsp/fix-unused-bindings-in-cases

    Fix unused-binding-detection in case patterns
    ChrisPenner committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    c32bb93 View commit details
    Browse the repository at this point in the history
  13. Update .github/workflows/nix-dev-cache.yaml

    Co-authored-by: Greg Pfeil <greg@technomadic.org>
    aryairani and sellout committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    6cb39c8 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    69886f4 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    97c9109 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2024

  1. Configuration menu
    Copy the full SHA
    c049c65 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f63cfbe View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Configuration menu
    Copy the full SHA
    7909114 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Configuration menu
    Copy the full SHA
    4c3eb03 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Merge trunk

    ChrisPenner committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    82e9516 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bab6e99 View commit details
    Browse the repository at this point in the history