Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ptl version 200 #1651

Merged
merged 3 commits into from Mar 20, 2023
Merged

Fix/ptl version 200 #1651

merged 3 commits into from Mar 20, 2023

Conversation

dennisbader
Copy link
Collaborator

Summary

fixes the issues with the new PyTorch-Lightning=2.0.0 release:

  • fixes minor issue when checking for ptl>=1.6.0
  • fixes precision issues from their new naming convention (see here
  • fixes a failing probablistic NBEATSModel test

Other Information

  • had to increase the number of training epochs for the failing probabilistic NBEATSModel test. Not sure why the results are not the same anymore, probably from some changes on pytorch-lightning / pytorch side

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2023

Codecov Report

Patch coverage: 92.85% and project coverage change: -0.08 ⚠️

Comparison is base (f7c292a) 94.13% compared to head (80d7735) 94.06%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1651      +/-   ##
==========================================
- Coverage   94.13%   94.06%   -0.08%     
==========================================
  Files         125      125              
  Lines       11340    11337       -3     
==========================================
- Hits        10675    10664      -11     
- Misses        665      673       +8     
Impacted Files Coverage Δ
...arts/models/forecasting/torch_forecasting_model.py 89.90% <92.30%> (-0.02%) ⬇️
darts/models/forecasting/pl_forecasting_module.py 93.89% <100.00%> (ø)

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@madtoinou madtoinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dennisbader dennisbader merged commit 8b2df75 into master Mar 20, 2023
9 checks passed
@dennisbader dennisbader deleted the fix/ptl_version_200 branch March 20, 2023 09:57
alexcolpitts96 pushed a commit to alexcolpitts96/darts that referenced this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants