Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing test when lightning version <2.0.0 #1654

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

dennisbader
Copy link
Collaborator

Summary

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (8b2df75) 94.07% compared to head (6b1f88e) 94.06%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1654      +/-   ##
==========================================
- Coverage   94.07%   94.06%   -0.01%     
==========================================
  Files         125      125              
  Lines       11351    11337      -14     
==========================================
- Hits        10678    10664      -14     
  Misses        673      673              

see 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@madtoinou madtoinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dennisbader dennisbader merged commit afc2c3c into master Mar 20, 2023
@dennisbader dennisbader deleted the fix/failing_test_with_precisions branch March 20, 2023 16:08
alexcolpitts96 pushed a commit to alexcolpitts96/darts that referenced this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants