Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: replace isort with Ruff's rule I #2339

Merged
merged 5 commits into from
Apr 18, 2024

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Apr 17, 2024

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Follow-up to #2195 and #2323

Summary

isort functionality are fully covered with I rule

Other Information

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.01%. Comparing base (8f8b514) to head (b3bab94).
Report is 1 commits behind head on master.

❗ Current head b3bab94 differs from pull request most recent head 05fe2d3. Consider uploading reports for the commit 05fe2d3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2339   +/-   ##
=======================================
  Coverage   94.01%   94.01%           
=======================================
  Files         138      138           
  Lines       14187    14187           
=======================================
  Hits        13338    13338           
  Misses        849      849           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @Borda, also for quickly adding the changelog entry 🚀

@dennisbader dennisbader merged commit 979a4a3 into unit8co:master Apr 18, 2024
9 checks passed
@Borda Borda deleted the ruff/I branch April 18, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants