-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename master branch to main #2259
Comments
@natestemen @FarLab @purva-thakre Happy with this plan? |
LGTM! I'd just add that I think step 2 should come first, and then just before merging said PR, step 1 should be taken followed by 3. Then, there could be a step 4 as well. Something like
This should help prevent things from getting into a bad state by starting the process, and not finishing it in one fell swoop. |
Okey doke. Sounds good. So the final plan would be
|
Do we want to leave the existing changelog saying "master" since that's what it was called when past changes were made? |
I think it's probably best to use |
Yeah I agree. Use master for old entries to the change log and main going
forward.
…On Tue, Apr 2, 2024, 1:04 PM nate stemen ***@***.***> wrote:
I think it's probably best to use main going forward, but not to change
it in the changelog for things prior to this change. I can see reasons for
both decisions, but I lean this way. Do you have a preference?
—
Reply to this email directly, view it on GitHub
<#2259 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADYYB53MT7X52B7CNRX6K3LY3MFMDAVCNFSM6AAAAABFT4LDNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZTGAYDCNZUGA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
I'm not quite sure a good way to update the changelog to say we've made this change since it isn't a release. Any suggestions for format? |
Since you have a PR with that, isn't it going to show up automatically in the changelog? |
Yup this will get populated in the changelog when the next release is done! |
To be more in line with default naming for primary branches in the industry: https://github.com/github/renaming
I think since github will redirect master links to main (according to https://github.com/github/renaming?tab=readme-ov-file#whats-already-changed), the best thing to do is
Change the name of
master
tomain
via this GUI:Changing the name may still break CI/CD, but it should be fixed after step 3.
Create a branch where we'll replace all the instances of "master" with "main" in our documentation, tutorials, and actions.
Merge this branch into the newly named
main
branchThe text was updated successfully, but these errors were encountered: