loosen remaining core dependency versions #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natestemen
added
tech debt
|
|
Codecov Report
@@ Coverage Diff @@
## master #1917 +/- ##
========================================
Coverage 98.47% 98.47%
========================================
Files 77 79 +2
Lines 3545 3681 +136
========================================
+ Hits 3491 3625 +134
- Misses 54 56 +2 |
andreamari
approved these changes
Jul 17, 2023
andreamari
approved these changes
Jul 17, 2023
natestemen
force-pushed
the
nts-loosen-core-deps
branch
from
46b0237
to
5a7e4a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #1672 we loosened the version requirement for
numpyand haven't had any complaints from users in regards to irreproducible bugs/inconsistencies.We could do each one of these dependencies at a time, but considering how little we use
scipy, I think this should be fine to go out as one. Happy to change if others have different opinions.Fixes #1667