Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove binder links #1970

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Remove binder links #1970

merged 1 commit into from
Aug 18, 2023

Conversation

andreamari
Copy link
Member

@andreamari andreamari commented Aug 18, 2023

This PR removes the unstable/not-working mybinder badge, a few links pointing to it and a bot posting it to each new PR.

Based on discussion and decision taken in #1724.
Fixes #1724.

Related to #1820.


License

  • [ x] I license this contribution under the terms of the GNU GPL, version 3 and grant Unitary Fund the right to provide additional permissions as described in section 7 of the GNU GPL, version 3.

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch unitaryfund/mitiq/remove-binder-badge

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #1970 (c8e2d99) into master (ce61b82) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1970      +/-   ##
==========================================
+ Coverage   98.27%   98.30%   +0.02%     
==========================================
  Files          86       86              
  Lines        4068     4068              
==========================================
+ Hits         3998     3999       +1     
+ Misses         70       69       -1     

see 1 file with indirect coverage changes

Copy link
Contributor

@Misty-W Misty-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @andreamari, LGTM!

@Misty-W Misty-W merged commit cc7a2fa into master Aug 18, 2023
22 checks passed
@Misty-W Misty-W deleted the remove-binder-badge branch August 18, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Binder badge is failing
2 participants