Remove "binder" remnants #2071
Merged
Remove "binder" remnants #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natestemen
added
infrastructure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2071 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 87 87
Lines 4125 4125
=======================================
Hits 4055 4055
Misses 70 70 ☔ View full report in Codecov by Sentry. |
Misty-W
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Thanks @natestemen ! Looks fine to merge once the docs and RTD finish.
|
RTD finished and did indeed build (if got the ❌ because the known problem about the builds taking a long time). Going ahead with merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we no longer use/advertise the use of mybinder (#1970), we can remove the
binderdirectory. Support for binder was originally added in #841.