adding rotated randomized benchmarking circuits to calibrator

[FarLab]

Description

This PR will add rotated randomized benchmarking circuits to the calibrator settings as was requested in #2065.

---

License

• I license this contribution under the terms of the GNU GPL, version 3 and grant Unitary Fund the right to provide additional permissions as described in section 7 of the GNU GPL, version 3.

Before opening the PR, please ensure you have completed the following where appropriate.

• I added unit tests for new code.
• I used type hints in function signatures.
• I used Google-style docstrings for functions.
• I updated the documentation where relevant.
• Added myself / the copyright holder to the AUTHORS file

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.28%. Comparing base (b9036cf) to head (4725b8a).
Report is 7 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2248   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files          90       90           
  Lines        4257     4264    +7     
=======================================
+ Hits         4184     4191    +7     
  Misses         73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[natestemen]

After checking out this branch I was able to do the following.

$ make format
ruff check --fix
mitiq/calibration/settings.py:344:80: E501 Line too long (80 > 79)
mitiq/calibration/settings.py:345:80: E501 Line too long (98 > 79)
mitiq/calibration/settings.py:348:80: E501 Line too long (90 > 79)
Found 5 errors (2 fixed, 3 remaining).

The errors on lines 344, 345, and 348 of mitiq/calibration/settings.py will need to be corrected by hand. If this doesn't work for you let me know and I can push the fix!

output of git diff after running make format

diff --git a/mitiq/calibration/settings.py b/mitiq/calibration/settings.py
index 4616fe5d..3c592690 100644
--- a/mitiq/calibration/settings.py
+++ b/mitiq/calibration/settings.py
@@ -18,8 +18,8 @@ from mitiq.benchmarks import (
     generate_mirror_circuit,
     generate_quantum_volume_circuit,
     generate_rb_circuits,
+    generate_rotated_rb_circuits,
     generate_w_circuit,
-    generate_rotated_rb_circuits
 )
 from mitiq.interface import convert_from_mitiq
 from mitiq.pec import execute_with_pec
diff --git a/mitiq/calibration/tests/test_settings.py b/mitiq/calibration/tests/test_settings.py
index fe37751f..f1c4f0c1 100644
--- a/mitiq/calibration/tests/test_settings.py
+++ b/mitiq/calibration/tests/test_settings.py
@@ -5,8 +5,8 @@
 import json
import cirq

-import pytest

import numpy as np

+import pytest

import qiskit
from mitiq import QPROGRAM, SUPPORTED_PROGRAM_TYPES

[FarLab]

Thanks for checking Nate, I'll try correct the errors on lines 344, 345, and 348 of mitiq/calibration/settings.py.

[cosenal]

In the code, you are branching off logic based on the number of qubits. You want at least one test for each of the two logical branches.

[FarLab]

you are right!

[cosenal]

Why not using a variable, say p, for this expression and then 1 - p as expression for "1".

[FarLab]

good point, that is cleaner

[cosenal]

LGTM

Note: I haven't checked the math from the issue discussion, so I would feel more comfortable with a second review from somebody who has.