Exit early when circuit type is not supported #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2252 +/- ##
==========================================
- Coverage 98.28% 98.28% -0.01%
==========================================
Files 90 90
Lines 4257 4256 -1
==========================================
- Hits 4184 4183 -1
Misses 73 73 ☔ View full report in Codecov by Sentry. |
natestemen
approved these changes
Mar 29, 2024
cosenal
added a commit
that referenced
this pull request
Jun 26, 2024
* Exit early when circuit type is not supported * Remove unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A small thing I noticed when reviewing #2248. Unless I am missing something, there is no point in generating the circuit for a circuit type we don't support.
make testpasses successfully.