Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin myst-parser #2317

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Pin myst-parser #2317

merged 1 commit into from
Apr 25, 2024

Conversation

cosenal
Copy link
Contributor

@cosenal cosenal commented Apr 23, 2024

Myst-parser 3.0.0 was released today and that was breaking our builds.

My bad, I left this dependency too loose in #2269, and it's causing builds to fail, e.g. https://github.com/unitaryfund/mitiq/actions/runs/8807617694

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.23%. Comparing base (8c24a9b) to head (8a24403).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2317      +/-   ##
==========================================
- Coverage   98.30%   98.23%   -0.08%     
==========================================
  Files          91       87       -4     
  Lines        4308     4068     -240     
==========================================
- Hits         4235     3996     -239     
+ Misses         73       72       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@natestemen natestemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@natestemen natestemen merged commit 9e1cbb5 into main Apr 25, 2024
16 of 18 checks passed
@natestemen natestemen deleted the pin-myst-parser branch April 25, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants