Upgrade Qiskit to 1.0.2 #2269

andre-a-alves · 2024-04-07T15:10:31Z

Description

Upgrades Qiskit to 1.0.2 and introduces a TransformationPass for transforming QuantumRegisters.

Out of Scope

~~Docs have not been updated to Qiskit 1.0. Some examples from the docs use qiskit.execute() and remain incompatible with Qiskit 1.0.~~

License

I license this contribution under the terms of the GNU GPL, version 3 and grant Unitary Fund the right to provide additional permissions as described in section 7 of the GNU GPL, version 3.

Before opening the PR, please ensure you have completed the following where appropriate.

I added unit tests for new code.
I used type hints in function signatures.
I used Google-style docstrings for functions.
I updated the documentation where relevant.
Added myself / the copyright holder to the AUTHORS file

andre-a-alves · 2024-04-08T03:30:39Z

This morning I took a look at the failing job. The Python 3.9 failures all relate to a dependency conflict involving Sphinx, the Sphinx theme, and nbsphinx, which is unrelated to this PR. Later this week I can look into why the docs are failing. I did not update the examples that use qiskit.execute(), so that could be it, in which case I can update them in the troubleshooting.

andre-a-alves · 2024-04-08T03:40:30Z

Also, the 3.11 failure seems to be an issue with Codecov:
Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

cosenal · 2024-04-11T15:16:57Z

Also, the 3.11 failure seems to be an issue with Codecov: Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

This was resolved by #2271. If you rebase main into your branch, and restart the test build, it should be fixed.

cosenal · 2024-04-11T15:20:42Z

This morning I took a look at the failing job. The Python 3.9 failures all relate to a dependency conflict involving Sphinx, the Sphinx theme, and nbsphinx, which is unrelated to this PR. Later this week I can look into why the docs are failing. I did not update the examples that use qiskit.execute(), so that could be it, in which case I can update them in the troubleshooting.

The docs build is failing, as you suspected, because the qiskit notebooks from the examples haven't been updated.

…2204/update_qiskit_to_1.0.2

codecov · 2024-04-14T02:35:13Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.32%. Comparing base (37a202b) to head (27a7fd2).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2269      +/-   ##
==========================================
+ Coverage   98.29%   98.32%   +0.03%     
==========================================
  Files          90       91       +1     
  Lines        4274     4308      +34     
==========================================
+ Hits         4201     4236      +35     
+ Misses         73       72       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

andre-a-alves · 2024-04-14T08:07:01Z

main was merged into the branch, and I updated the docs. The only remaining failures seem to be unrelated to this PR and have to do with incompatible depends in Python 3.9.

cosenal · 2024-04-14T09:41:29Z

Thanks, @andre-a-alves.

The only remaining failures seem to be unrelated to this PR and have to do with incompatible depends in Python 3.9.

They are technically related to this PR in the sense that the conflicts are caused by the new dependencies introduced in this PR. In fact a clean build from the main branch on Python 3.9 is still working. I am not sure why in this PR it's trying to install myst-parser 1.0.0 on Python 3.9 🤷‍♂️ I pushed a commit to pin myst-parser to >= 2.0.0, let's see if it works.

Also note the plan for Mitiq to drop support for Python 3.9 soon, see #2215.

andre-a-alves · 2024-04-14T09:44:32Z

I did not realize. If it doesn't pass with the myst-parser pin, this evening I'll look for a combination of dependencies that work.

mitiq/interface/mitiq_qiskit/conversions.py

cosenal · 2024-04-15T13:01:30Z

mitiq/interface/mitiq_qiskit/transpiler.py

+# Modification made by: André Alves on 07 Apr 2024
+#
+# For the original code and license, see
+# https://github.com/Qiskit/qiskit/blob/stable/1.0/qiskit/transpiler/passes/layout/apply_layout.py


License-wise, it's all good. My concern about having this file in mitiq is that it's going to be hard to keep it synced with the upstream qiskit file. Can't we just use the imported functions as they are, and wrap them where needed?

The idea is not to keep them in sync. I used a lot of the original ApplyLayout, but I made substantive changes that are different from the original. The original class applies a QuantumRegister with the name q. We initialize the class with our own registers, and we use their names. From what I understand, maintaining the names is one of the purposes of the _transform function. But with probably half the class identical to the original, I thought it appropriate to include the license statement.

cosenal

LGTM 🚀
Since it's quite a big change, let's wait for a second review before merging.

nathanshammah · 2024-04-16T15:22:45Z

Nice work @andre-a-alves!!

natestemen

Awesome work Andre! Thanks for the help on this 💪🏻.

I've left a few small comments, but all the major stuff is there. Qiskit users will be very grateful!

docs/source/examples/mitiq-paper/mitiq-paper-codeblocks.md

docs/source/examples/simple-landscape-braket.md

docs/source/examples/ibmq-backends.md

docs/source/examples/pennylane-ibmq-backends.md

mitiq/interface/mitiq_qiskit/qiskit_utils.py

mitiq/interface/mitiq_qiskit/tests/test_transpiler.py

mitiq/interface/mitiq_qiskit/transpiler.py

andre-a-alves · 2024-04-17T18:47:36Z

Awesome work Andre! Thanks for the help on this 💪🏻.

I've left a few small comments, but all the major stuff is there. Qiskit users will be very grateful!

All comments addressed in latest commit. Good catches! Thank you for the review!

natestemen

* updates dev_requirements for Qiskit 1.0.2 * updates qiskit_utils to not use execute * updates conversions to use qasm2.dumps * updates I gate * adds TransformationPass to _transform_registers * updates test * updates zne tests * fixes ddd tests * fixes pec tests * fixes zne scaling tests * adds tests for transpiler * updates aer version * updates docs examples * slightly refactors qiskit transpilations * updates mitiq paper codeblock * pin myst-parser dependency * fixes docstring and adds tests for multi-register circuit * applies suggestions from comments --------- Co-authored-by: Alessandro Cosentino <alessandro@unitary.fund>

andre-a-alves added 12 commits April 7, 2024 15:47

updates dev_requirements for Qiskit 1.0.2

07dbbda

updates qiskit_utils to not use execute

fc11660

updates conversions to use qasm2.dumps

b2bf73d

updates I gate

32277ad

adds TransformationPass to _transform_registers

f7dd496

updates test

04806d6

updates zne tests

77611f9

fixes ddd tests

2f8213b

fixes pec tests

5e0a885

fixes zne scaling tests

ef962bc

adds tests for transpiler

acdea54

updates aer version

05bb8e0

purva-thakre mentioned this pull request Apr 11, 2024

Update qiskit requirement from ~=0.45.1 to ~=1.0.1 #2207

Closed

Merge remote-tracking branch 'refs/remotes/upstream/main' into issue_…

1f2d687

…2204/update_qiskit_to_1.0.2

andre-a-alves added 2 commits April 14, 2024 07:49

updates docs examples

bc316be

slightly refactors qiskit transpilations

7b07825

andre-a-alves added priority/high Needs to be fixed ASAP & no later than the next milestone. interface-and-conversions How Mitiq interfaces with quantum software packages. labels Apr 14, 2024

updates mitiq paper codeblock

6fb6aa9

pin myst-parser dependency

91574dd

cosenal reviewed Apr 15, 2024

View reviewed changes

fixes docstring and adds tests for multi-register circuit

9ca5a5d

cosenal approved these changes Apr 15, 2024

View reviewed changes

cosenal requested review from natestemen and purva-thakre April 15, 2024 15:49

natestemen reviewed Apr 17, 2024

View reviewed changes

applies suggestions from comments

27a7fd2

natestemen approved these changes Apr 18, 2024

View reviewed changes

FarLab merged commit 5365e7a into unitaryfund:main Apr 19, 2024
16 checks passed

cosenal mentioned this pull request Apr 23, 2024

Pin myst-parser #2317

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Qiskit to 1.0.2 #2269

Upgrade Qiskit to 1.0.2 #2269

andre-a-alves commented Apr 7, 2024 •

edited by cosenal

Loading

andre-a-alves commented Apr 8, 2024

andre-a-alves commented Apr 8, 2024

cosenal commented Apr 11, 2024

cosenal commented Apr 11, 2024

codecov bot commented Apr 14, 2024 •

edited

Loading

andre-a-alves commented Apr 14, 2024

cosenal commented Apr 14, 2024

andre-a-alves commented Apr 14, 2024

cosenal Apr 15, 2024 •

edited

Loading

andre-a-alves Apr 15, 2024

cosenal left a comment

nathanshammah commented Apr 16, 2024

natestemen left a comment

andre-a-alves commented Apr 17, 2024

natestemen left a comment

Upgrade Qiskit to 1.0.2 #2269

Upgrade Qiskit to 1.0.2 #2269

Conversation

andre-a-alves commented Apr 7, 2024 • edited by cosenal Loading

Description

Out of Scope

License

andre-a-alves commented Apr 8, 2024

andre-a-alves commented Apr 8, 2024

cosenal commented Apr 11, 2024

cosenal commented Apr 11, 2024

codecov bot commented Apr 14, 2024 • edited Loading

Codecov Report

andre-a-alves commented Apr 14, 2024

cosenal commented Apr 14, 2024

andre-a-alves commented Apr 14, 2024

cosenal Apr 15, 2024 • edited Loading

Choose a reason for hiding this comment

andre-a-alves Apr 15, 2024

Choose a reason for hiding this comment

cosenal left a comment

Choose a reason for hiding this comment

nathanshammah commented Apr 16, 2024

natestemen left a comment

Choose a reason for hiding this comment

andre-a-alves commented Apr 17, 2024

natestemen left a comment

Choose a reason for hiding this comment

andre-a-alves commented Apr 7, 2024 •

edited by cosenal

Loading

codecov bot commented Apr 14, 2024 •

edited

Loading

cosenal Apr 15, 2024 •

edited

Loading