Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #353 "Vector2/3 reference not properly showing" #359

Merged
merged 2 commits into from
Oct 22, 2022

Conversation

soraphis
Copy link
Collaborator

@soraphis soraphis commented Jun 25, 2022

fixes #353 and #357

The code before #289 has handled properties with custom-one-line-drawers (like Vector3) correctly, but did not handle custom structs - when collapsed - correctly.

this fix is the best of both worlds:

  • Get the property height of the property if it would be expanded,
  • then decided based upon whether or not it would occupy multiple lines.

image

image

this also fixes the broken StringReferences mentioned in (#357)

image

@jackalopy
Copy link

Please, pretty please, give this a little bit of attention. It should help us all <3

@soraphis soraphis added this to the v4.4.6 milestone Oct 17, 2022
Copy link
Collaborator

@AdamRamberg AdamRamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! ⭐️ The code looks good to me! Pushed a smaller fix before the merge with a height adjustment of the popup button, which was covering the click area for underlying props when testing a struct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants