Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main content section too small on small screen #103

Closed
LeLocTai opened this issue Mar 25, 2021 · 6 comments
Closed

Main content section too small on small screen #103

LeLocTai opened this issue Mar 25, 2021 · 6 comments
Assignees
Labels
documentation Improvements or additions to documentation type:feedback Issue containing feedback. Can submitted via the website.

Comments

@LeLocTai
Copy link

I usually use a viewport width of 1280px when browsing the web. At this size, the main content section is too small, making the code block very inconvenience to read, compared to the old docfx theme. Also images overflow and is overlap with the table of content.

Here is an example:

image

Compared to the old package docs, which use the space a lot better, and I can read the code comfortably:

image

@LeLocTai LeLocTai added the type:feedback Issue containing feedback. Can submitted via the website. label Mar 25, 2021
@Briancoughlin Briancoughlin added the documentation Improvements or additions to documentation label Mar 25, 2021
@Briancoughlin
Copy link
Collaborator

Briancoughlin commented Mar 25, 2021

Images do overlap with the MINI TOC , which is absent from the Main Unity Docs, and we dont wrap code but maintain the formatting. This will come down to a user choice, do they like the Mini TOC/Non-wrapping of code or not. We may need more feedback on this should be a question at one of our group talks
.

@Briancoughlin
Copy link
Collaborator

Briancoughlin commented Mar 25, 2021

image
There isn't a large amount of real-estate size difference in the two pages at the 1280 width we can possibly tweak the Mini TOC width to match.

@LeLocTai
Copy link
Author

I think the a big contributor is the left padding on the main section.

Regarding the images, as the new site support click to zoom, scaling them down to fit should work fine

@Briancoughlin
Copy link
Collaborator

we will take a look make some changes and then post images here to see if it helps.

@lkrell lkrell self-assigned this Mar 25, 2021
@lkrell
Copy link
Contributor

lkrell commented Mar 25, 2021

I noticed we need to tweak the article size for that div. I'll check it out and get it going! Thanks for the feedback!

@Briancoughlin
Copy link
Collaborator

This has been addressed in PR #117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation type:feedback Issue containing feedback. Can submitted via the website.
Projects
None yet
Development

No branches or pull requests

3 participants