Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback for /docs/tutorials/helloworldintro.md #99

Closed
JustinMinnaar opened this issue Mar 24, 2021 · 4 comments
Closed

Feedback for /docs/tutorials/helloworldintro.md #99

JustinMinnaar opened this issue Mar 24, 2021 · 4 comments
Assignees
Labels
type:feedback Issue containing feedback. Can submitted via the website.

Comments

@JustinMinnaar
Copy link

I tried creating a new project, using the Package Manager, +, Github as instructed, however, I get the following error:

[Package Manager Window] Error adding package: https://github.com/Unity-Technologies/com.unity.multiplayer.mlapi.git?path=/com.unity.multiplayer.mlapi#0.1.0.
UnityEditor.EditorApplication:Internal_CallUpdateFunctions ()

I may be worthwhile to add this error and its resolution to this page, just in case anyone else hits it. I don't know what the resolution is or what this means.

@JustinMinnaar JustinMinnaar added the type:feedback Issue containing feedback. Can submitted via the website. label Mar 24, 2021
@Briancoughlin
Copy link
Collaborator

Briancoughlin commented Mar 24, 2021

@JustinMinnaar can you let me know if you copied using the copy button or copy via select all method? we have seen this reported in Discord that there can be a hidden HTML artefact space( thats not in the actual source). we will investigate this

@Briancoughlin
Copy link
Collaborator

Briancoughlin commented Mar 25, 2021

There doesn't appear to be any whitespace in the HTML generated.
<div class="token-line" style="color:#bfc7d5"><span class="token plain">https://github.com/Unity-Technologies/com.unity.multiplayer.mlapi.git?path=/com.unity.multiplayer.mlapi#0.1.0</span></div>

Not sure if we should try adding some whitespace stripping CSS to the style.

I propose adding a Guidance admonition as below

We recommend that you use the 'Copy' function in the code block above to copy the URL as other methods may result in errors.

@Briancoughlin
Copy link
Collaborator

image

This is the proposed update

@lkrell
Copy link
Contributor

lkrell commented Mar 25, 2021

Completed, this change will be live today. We are also updating the CSS to make the copy button brighter, easier to see!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feedback Issue containing feedback. Can submitted via the website.
Projects
None yet
Development

No branches or pull requests

3 participants