Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keys with no "up" state #44

Closed
patcolyn opened this issue Jul 14, 2018 · 4 comments
Closed

Keys with no "up" state #44

patcolyn opened this issue Jul 14, 2018 · 4 comments

Comments

@patcolyn
Copy link

patcolyn commented Jul 14, 2018

Describe the bug
When using a key with no natural up/down state (eg. scroll) the overlay does not display/update as expected.

To Reproduce

No input:

  1. Input scroll
  2. Do not provide input
  3. Overlay keeps scroll highlighted until input is provided

Constant Input:

  1. Provide high number of inputs (move cursor) for duration
  2. scroll
  3. Overlay only shows input for one frame, not visible

Expected behavior
Mouse overlay shows scroll inputs visibly

Screenshots
image

Additional information:

@univrsal
Copy link
Owner

I am aware of this bug. This is because of how the input library works.
It only sends a event when the users is scrolling but it doesn't send one when the user stops scrolling, which means I disable scrolling everytime any type of event is sent (eg. Mouse movement) and enable scrolling when the scrolling event is set, which results in the flickering scroll texture when you move your mouse and scroll at the same time.

As of now I have not found a way to prevent this from happening, but I'm open to suggestions

@patcolyn
Copy link
Author

I looked through the source and the way you implemented it is likely the most sensible one, though can cause issues with high polling rate mice.

I guess a usability alternative would be to highlight the texture for a set duration, say 25ms as an example. Refresh the 25ms highlight timer every event for continuously scrolling. Would give similar feedback to a single click, but this solution would not communicate a specific number of events.

@univrsal
Copy link
Owner

univrsal commented Jul 16, 2018

We'll see, maybe I can come up with a solution at some point

@univrsal
Copy link
Owner

Just a little heads up, I added a timer which will reset the scrolling after 120ms of no scrolling event.
It'll be in 5.0, once it's ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants