Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update git-authors - remove "WHERE" #684

Closed
wants to merge 1 commit into from
Closed

Conversation

izikeros
Copy link

@izikeros izikeros commented Jul 4, 2024

Having "WHERE" in:

git log --pretty=format:'%an <%ae>' "$WHERE" | sort | uniq -c | sort -nr

was breaking the command. "WHERE" was removed, what fixes the command.

Copy link

codeclimate bot commented Jul 4, 2024

Code Climate has analyzed commit 9cf27e6 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Owner

@unixorn unixorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without $WHERE, you'll always get the authors for the entire repository. With it, you can get just the authors in a given directory tree, and we're currently defaulting to the current directory.

I think making the default value of $WHERE be the root of the git checkout is a reasonable compromise though. You can find that with git rev-parse --show-toplevel.

@izikeros
Copy link
Author

izikeros commented Jul 5, 2024

Please close this PR (without merging), there is no issue with $WHERE - I was using it wrong way. Sorry for the confusion.

@unixorn
Copy link
Owner

unixorn commented Jul 6, 2024

Closing as requested - #683 was user error

@unixorn unixorn closed this Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants