Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hope to fix "uWebSocket. js": "GitHub: uNetworking/uWebSocket. js # v23.3.0" to a normal dependency. #51

Closed
1 task
SKT1yang opened this issue Jul 24, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@SKT1yang
Copy link

Describe the feature

In an offline internal network environment, we have a self built npm private server, but it relies on uWebSocket. js to try downloading the dependency from another network address: "uWebSocket. js": "GitHub: uNetworking/uWebSocket. js # v23.3.0", which caused us to download the dependency and cannot be used normally. We hope to fix this dependency to a normal dependency.
The entire dependency relationship is @ eslint/config observer v0.5.2->h3 v1.12.0->crossws v 0.2.4
image

Additional information

  • Would you be willing to help implement this feature?
@SKT1yang SKT1yang added the enhancement New feature or request label Jul 24, 2024
@victorpinheiro
Copy link

+1
We have the exact same issue here. Hope it can be added as a normal dependency instead

@pi0
Copy link
Member

pi0 commented Jul 31, 2024

Sadly the author of uWebSocket.js does not trust the npm registry and because of licensing/credit issues, no one is at liberty to publish it there...

Although it is an optional peer dep of CrossWS, sadly some package managers also don't respect it and fail CIs...

Since it is a type-only dependency I'm gonna remove it for next release 👍🏼

@pi0
Copy link
Member

pi0 commented Aug 6, 2024

it will be removed in next release (semver major 0.3.x)

@pi0 pi0 closed this as completed Aug 6, 2024
@victorpinheiro
Copy link

Hi @pi0, sorry bothering you again with it. Do you have any idea of when the next release will happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants