Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Node.js upstream changes for resolve implementation #134

Closed
pi0 opened this issue Jan 5, 2023 · 2 comments
Closed

Update for Node.js upstream changes for resolve implementation #134

pi0 opened this issue Jan 5, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@pi0
Copy link
Member

pi0 commented Jan 5, 2023

Implementation of resolver is based on import-meta-resolve based on Node.js code at https://github.com/nodejs/node/blob/89f592c/lib/internal/modules/esm/resolve.js. Latest changes might need to be applied https://github.com/nodejs/node/blob/main/lib/internal/modules/esm/resolve.js into https://github.com/unjs/mlly/blob/main/lib/import-meta-resolve/resolve.js and probably wooorm/import-meta-resolve#11

@pi0 pi0 added the enhancement New feature or request label Jan 5, 2023
@pi0 pi0 changed the title Update for upstream changes for resolve implementation Update for Node.js upstream changes for resolve implementation Jan 5, 2023
@pi0
Copy link
Member Author

pi0 commented Jan 5, 2023

@pi0
Copy link
Member Author

pi0 commented Jan 9, 2023

Fixed by using upstream wooorm/import-meta-resolve@05c1bea

@pi0 pi0 closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant