Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: findTypeExports for finding type exports #156

Merged
merged 7 commits into from Mar 10, 2023
Merged

feat: findTypeExports for finding type exports #156

merged 7 commits into from Mar 10, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds support for finding type exports which might be useful for type auto-import downstream in unimport (unjs/unimport#218) - as well as in https://github.com/unjs/mkdist (unjs/mkdist#134).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the enhancement New feature or request label Mar 10, 2023
@danielroe danielroe requested a review from pi0 March 10, 2023 11:27
@danielroe danielroe self-assigned this Mar 10, 2023
@danielroe danielroe requested a review from antfu March 10, 2023 11:27
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #156 (23237ac) into main (8368caa) will increase coverage by 0.66%.
The diff coverage is 96.51%.

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   84.53%   85.20%   +0.66%     
==========================================
  Files           8        8              
  Lines         802      865      +63     
  Branches      145      156      +11     
==========================================
+ Hits          678      737      +59     
- Misses        124      128       +4     
Impacted Files Coverage Ξ”
src/analyze.ts 97.72% <96.51%> (-0.90%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

src/analyze.ts Outdated Show resolved Hide resolved
test/exports.test.ts Outdated Show resolved Hide resolved
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it LGTM!

@danielroe danielroe requested a review from pi0 March 10, 2023 12:20
@pi0 pi0 changed the title feat: add support for finding type exports feat: findTypeExports for finding type exports Mar 10, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’―

@pi0 pi0 merged commit a48974d into main Mar 10, 2023
@pi0 pi0 deleted the feat/type-re branch March 10, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants