Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last-Modified date format is wrong #1016

Closed
janjhnsn opened this issue Mar 3, 2023 · 0 comments · Fixed by #1017
Closed

Last-Modified date format is wrong #1016

janjhnsn opened this issue Mar 3, 2023 · 0 comments · Fixed by #1017

Comments

@janjhnsn
Copy link
Contributor

janjhnsn commented Mar 3, 2023

Environment

Nitro v2.2.3 and node v16.14.2

Reproduction

Last-Modified uses mtime format which is ISO (2009-06-29T11:11:40Z) The documentation for Last-Modified states the format should be day-name, day month year hour:minute:second GMT or in other words UTC format.

Most browsers don't care about the format and sends the same formatted string as If-Modified-Since. Other systems (in our case Azure Frontdoor) validates the format and returns an error.

Describe the bug

Last-Modified is in the wrong format. I will submit a pull request for this.

Additional context

No response

Logs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant