Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled tasks type on nitro options are incorrect #2283

Closed
noook opened this issue Mar 20, 2024 · 1 comment · Fixed by #2285
Closed

Scheduled tasks type on nitro options are incorrect #2283

noook opened this issue Mar 20, 2024 · 1 comment · Fixed by #2285

Comments

@noook
Copy link
Contributor

noook commented Mar 20, 2024

Environment

Nitro 2.9

Reproduction

— (I'll do the PR)

Describe the bug

https://github.com/unjs/nitro/blob/8a62e7dbaeeffb6dff533c7000aba51a5c85e479/src/types/nitro.ts#L342

The types are incorrect, it should be

 scheduledTasks?:  { [cron: string]: string[] }; 

I think maybe of having to handle the undefined case when we have no scheduled tasks, we could just make this property be an empty object as default (as it's assignable).

Additional context

No response

Logs

No response

@noook noook changed the title Scheduled tasks type on ntiro options are incorrect Scheduled tasks type on nitro options are incorrect Mar 20, 2024
@pi0 pi0 added invalid This doesn't seem right needs reproduction labels Mar 21, 2024
@pi0
Copy link
Member

pi0 commented Mar 21, 2024

Thanks for helping on this but please either make a proposal for enhancement and wait for discussion or an issue with reproduction next times 🙏🏼

@pi0 pi0 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2024
@pi0 pi0 closed this as completed in #2285 Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants