Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support base in useStorage(base?: string) and improve docs #1012

Merged
merged 4 commits into from
Mar 3, 2023

Conversation

Atinux
Copy link
Member

@Atinux Atinux commented Mar 3, 2023

πŸ”— Linked issue

Resolves #1008

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Support useStorage(base) as well as improving the documentation about storage.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@nuxt-studio
Copy link
Contributor

nuxt-studio bot commented Mar 3, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio β†—οΈŽ View Live Preview 671b02f

@Atinux
Copy link
Member Author

Atinux commented Mar 3, 2023

I added tests but I am struggling to make them work, no idea what is the signature of callhandler() 😬

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #1012 (0209224) into main (a615444) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 0209224 differs from pull request most recent head 671b02f. Consider uploading reports for the commit 671b02f to get more accurate results

@@            Coverage Diff             @@
##             main    #1012      +/-   ##
==========================================
+ Coverage   67.66%   67.69%   +0.03%     
==========================================
  Files          60       60              
  Lines        6161     6167       +6     
  Branches      692      692              
==========================================
+ Hits         4169     4175       +6     
  Misses       1982     1982              
  Partials       10       10              
Impacted Files Coverage Ξ”
src/rollup/plugins/storage.ts 98.76% <100.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Atinux Atinux requested a review from pi0 March 3, 2023 14:06
test/tests.ts Outdated Show resolved Hide resolved
@pi0 pi0 changed the title feat: support base in useStorage(base?: string) feat: support base in useStorage(base?: string) and improve docs Mar 3, 2023
@pi0 pi0 merged commit df86bcf into main Mar 3, 2023
@pi0 pi0 deleted the feat/storage-base branch March 3, 2023 14:44
@pi0 pi0 mentioned this pull request Mar 3, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose useStorage(base?)
2 participants