Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve types relative to custom tsconfig path #1041

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We now support a custom tsconfig path, but in that PR I neglected to ensure that the paths were resolved relative to the custom path if it were in a different directory.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Mar 10, 2023
@danielroe danielroe requested a review from pi0 March 10, 2023 22:10
@danielroe danielroe self-assigned this Mar 10, 2023
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #1041 (8ea96e0) into main (a6ce587) will increase coverage by 0.18%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##             main    #1041      +/-   ##
==========================================
+ Coverage   67.20%   67.38%   +0.18%     
==========================================
  Files          62       62              
  Lines        6287     6280       -7     
  Branches      707      707              
==========================================
+ Hits         4225     4232       +7     
+ Misses       2049     2034      -15     
- Partials       13       14       +1     
Impacted Files Coverage Ξ”
src/build.ts 41.58% <28.57%> (+2.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit b27d246 into main Mar 13, 2023
@pi0 pi0 deleted the fix/relative-tsconfig branch March 13, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants