fix: apply cached rules to overlaping wildcard patterns

[danielroe]

🔗 Linked issue

resolves #905
nuxt/nuxt#18745

❓ Type of change

• 📖 Documentation (updates to the documentation or readme)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

If a cached route rule is created for a path that would match but is not equal to a glob pattern, we do not currently cache it (because the entire handler can't be cached).

We can work around this by adding a duplicate handler that we will cache, that matches the more specific variant.

An example is where we have a glob /** handler but only wish to cache the path /foo or /foo/**. In this case we need to add new handlers to cover these more specific prefixes.

Note: I've added this in the runtime code because that's where the existing processing of route rules happens. It would of course be possible to move all of this code straightforwardly to

nitro/src/rollup/plugins/handlers.ts

Lines 20 to 26 in 6541373

	if (nitro.options.renderer) {
	handlers.push({
	route: "/**",
	lazy: true,
	handler: nitro.options.renderer,
	});
	}

, but that is also true of these lines of code and I think we must have a good reason to keep them there (such as potentially setting route rules at runtime).

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[codecov]

Codecov Report

Merging #906 (beefdbe) into main (fc0be2a) will increase coverage by 0.27%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##             main     #906      +/-   ##
==========================================
+ Coverage   67.48%   67.76%   +0.27%     
==========================================
  Files          59       59              
  Lines        5911     5968      +57     
  Branches      660      677      +17     
==========================================
+ Hits         3989     4044      +55     
- Misses       1913     1915       +2     
  Partials        9        9              

Impacted Files	Coverage Δ
src/rollup/plugins/handlers.ts	92.91% <95.23%> (+2.91%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[pi0]

This is a smart solution! I agree. I think would be better that we move this to handler generation in build time and reduce runtime overhead. Route rules should be pre-determined in build time if we expect them universally so should be fine...

[danielroe]

Updated. ✅

One comment - it's occurred to me that we also need to track nested conditions, for example:

/posts/test: { cache: false }
/posts/**: { cache: true }
/**: { cache: false }

My last commit should hopefully handle this as well.