fix(cache): remove rejected cache promise from pending list. #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
approved these changes
Feb 24, 2023
Codecov Report
@@ Coverage Diff @@
## main #995 +/- ##
==========================================
+ Coverage 67.67% 67.73% +0.06%
==========================================
Files 61 60 -1
Lines 6171 6133 -38
Branches 694 691 -3
==========================================
- Hits 4176 4154 -22
+ Misses 1985 1969 -16
Partials 10 10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
manniL
reviewed
Feb 24, 2023
manniL
approved these changes
Feb 28, 2023
|
@pi0 do you have time to review this change? It seems to me as quite a small fix for a very impactful problem. |
pi0
reviewed
Mar 6, 2023
src/runtime/cache.ts
Outdated
| } | ||
| } catch (error) { | ||
| // Make sure entries that reject get removed. | ||
| delete pending[key]; |
There was a problem hiding this comment.
I think we could limit scope of try catch around L94 only.
pi0
approved these changes
Mar 6, 2023
|
Thanks for the PR dear @tdekoning and sorry took long to review. |
pi0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
nuxt/nuxt#18926
β Type of change
π Description
Resolved nuxt/nuxt#18926.
Cached events that have rejected were kept inside the
pendinglist, causing later requests to the same event to reject as well. This led to events on the same path to never recover, because the code of the event was never called again after an error.π Checklist