Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tagToString in @unhead/ssr escapes JSON with no effect #218

Closed
vetruvet opened this issue Sep 8, 2023 · 1 comment
Closed

tagToString in @unhead/ssr escapes JSON with no effect #218

vetruvet opened this issue Sep 8, 2023 · 1 comment

Comments

@vetruvet
Copy link
Contributor

vetruvet commented Sep 8, 2023

Environment

@unhead/ssr 1.5.4

Reproduction

https://github.com/vetruvet/unhead-vue2-first-request-bug

Describe the bug

https://github.com/unjs/unhead/blob/main/packages/ssr/src/util/tagToString.ts#L53 runs after content is set so the escaping has no effect

Additional context

Fix PR incoming

Logs

No response
@vetruvet vetruvet mentioned this issue Sep 8, 2023
Merged
8 tasks
@harlan-zw
Copy link
Collaborator

Available in 1.5.5 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vetruvet @harlan-zw