Skip to content

Commit

Permalink
Revert "Regression experiment: Temporarily revert to returning 0 from…
Browse files Browse the repository at this point in the history
… bad achievement memory accesses."

This reverts commit a044d8c.
  • Loading branch information
hrydgard committed Aug 9, 2023
1 parent 3e682ea commit 50ea506
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions Core/RetroAchievements.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -166,13 +166,8 @@ static uint32_t read_memory_callback(uint32_t address, uint8_t *buffer, uint32_t
WARN_LOG(G3D, "RetroAchievements PeekMemory: Bad address %08x (%d bytes) (%08x was passed in)", address, num_bytes, orig_address);
}

// TEMPORARY EXPERIMENT:
// Revert to returning 0.
memset(buffer, 0, num_bytes);
return num_bytes;

// This tells rcheevos that the access was bad, which should now be handled properly.
// return 0;
return 0;
}

Memory::MemcpyUnchecked(buffer, address, num_bytes);
Expand Down

0 comments on commit 50ea506

Please sign in to comment.