Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use DisplayEntity as Hologram. #49

Open
Tracked by #54
vLuckyyy opened this issue Feb 2, 2024 · 6 comments
Open
Tracked by #54

Add option to use DisplayEntity as Hologram. #49

vLuckyyy opened this issue Feb 2, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@vLuckyyy
Copy link

vLuckyyy commented Feb 2, 2024

how it works: https://www.youtube.com/watch?v=0mCQe7PjVxs
Spigot has api for this: https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/entity/Display.html

@Guarmanda
Copy link

This option is really recent, but could be usefull. I would still understand why he would keep using protocollib, you have more control like this.

@unldenis
Copy link
Owner

unldenis commented Feb 3, 2024

Interesting, we might think about implementing it,
I've seen on the protocol and it's supported by 1.19.
I wonder, however, what advantages it would have compared to a "simple" text line?

@unldenis
Copy link
Owner

unldenis commented Feb 3, 2024

This option is really recent, but could be usefull. I would still understand why he would keep using protocollib, you have more control like this.

Because by using packets, I don't register holograms on the server but only on the client, and thanks to the pool everything is asynchronous. It's a question of performance.

@vLuckyyy
Copy link
Author

vLuckyyy commented Feb 6, 2024

Interesting, we might think about implementing it, I've seen on the protocol and it's supported by 1.19. I wonder, however, what advantages it would have compared to a "simple" text line?

The DisplayEntities has a new additional properties such as, hologram size, hologram background color, and position.

For example:

image

@vLuckyyy
Copy link
Author

vLuckyyy commented Feb 6, 2024

Additional, im says, displayentites has billboard (position) property, example from spigot-api:

https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/entity/Display.Billboard.html

image

@vLuckyyy
Copy link
Author

vLuckyyy commented Feb 6, 2024

This option is really recent, but could be usefull. I would still understand why he would keep using protocollib, you have more control like this.

Because by using packets, I don't register holograms on the server but only on the client, and thanks to the pool everything is asynchronous. It's a question of performance.

Yes, i show spigot-api documentation, only for example.

@unldenis unldenis added the enhancement New feature or request label Feb 6, 2024
@vLuckyyy vLuckyyy changed the title Add option to use DisplatEntity as Hologram. Add option to use DisplayEntity as Hologram. Feb 19, 2024
@unldenis unldenis mentioned this issue Apr 25, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants