-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(unlock-app): Allow processing of large csvs #14055
Conversation
Thank you for your pull request and welcome to Unlock! We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @iMac7 on file. |
Thank you for your pull request and welcome to Unlock! We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @iMac7 on file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Could you do a a small screen record with an example of how that behaves?
I wonder if we could just "skip" the wait once the tx has been submitted and just move on to the next one without having to wait for it to be mined?
…into process-large-csvs
https://www.loom.com/share/53879714d55747838de39c69161235e4 I used a |
Thanks @iMac7 ! I believe it would be nice to add some kind of loading indicator to the UI, maybe replacing the the "drag and drop" area, showing that X transactions are being mined? What do you think? |
Good idea, I'll take a look at that. The text that said the user should reupload a csv should be replaced as well, what do I put there? |
We should probably remove that text in fact and replace with something like this:
|
@iMac7 Do you mind showing a quick video again with the updated loading state? |
https://www.loom.com/share/8106d1ca03934774a71e92dc6f383042?sid=59ab7a74-2f3d-43ed-bce1-cf93c802b35d I've not added number of transactions because they're processed in parallel anyway (lmk if the number is important) |
Amazing! LGTM! |
Description
Currently, only 50 entries are processed at a time and the user has to enter the csv again to process the next 50.
This PR loads the entire csv and queues the transactions into groups of 50 (maximum). Each group of transactions must be signed.
Issues
Fixes #12993
Checklist:
Release Note Draft Snippet