chore: proper logging for protocol health monitoring with Sentry #14072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemsos
commented
Jun 19, 2024
There was a problem hiding this comment.
There are several logger.js files with duplicate code but as we discussed , it may be easier to have these for now than to introduce another package just to hold that bit of code.
|
relates to #13917 |
clemsos
commented
Jun 20, 2024
| console.log(`${symbols[level] || ''}[${level}]: ${msg}`) | ||
|
|
||
| // send to sentry | ||
| if (process.env.SENTRY_DSN) { |
There was a problem hiding this comment.
logs will be sent to sentry only if SENTRY_DSN is exported to the shell. Should document this maybe but not sure where ?
clemsos
changed the title
julien51
approved these changes
Jun 20, 2024
| console.log(`${symbols[level] || ''}[${level}]: ${msg}`) | ||
|
|
||
| // send to sentry | ||
| if (process.env.SENTRY_DSN) { |
clemsos
commented
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a more refined and useful way to log various protocol checks to Sentry (and then fwd them to discord etc)
Issues
Fixes #
Refs #
Checklist:
Release Note Draft Snippet