Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production Deploy #14063

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Production Deploy #14063

merged 5 commits into from
Jun 18, 2024

Conversation

julien51
Copy link
Member

@julien51 julien51 commented Jun 18, 2024

Production manual Deploy production-20240617-210937

This is a production deployment. Please treat with great caution!
This deploys the code from the master branch as of commit 2c21135.

Reviewing this Pull Request's code is impractical; however, you are asked to check whether the current staging environment is stable and could be released. For this, follow these steps:

  • The staging environment has been fully deployed
  • This pull request has no conflicts with the production branch.
  • Go to http://staging.unlock-protocol.com/ and ensure that the website loads fine.

Creator Dashboard

  • Click on the "Go to your Dashboard" button and ensure that the dashboard loads as expected
  • Create a new Lock (using a test net is the best option) and wait for it to confirm with the right values
  • Update the price on this new lock or an older lock
  • Enable credit cards on one of your locks
  • Withdraw funds on one of the locks

Paywall

  • From the dashboard, open the Demo on one of your locks
  • Purchase a key to the lock using your crypto wallet
  • Make sure the content gets unlocked (is shown)
  • Refresh the page and make sure the content is still unlocked

Purchase URL

  • From the dashboard, create a purchase URL (redirect URL does not matter)
  • In the purchase URL, configure metadata collection to collect an email address, as well as at least one other of data
  • By using a recent lock, enable multiple purchases in the URL
  • Go through the checkout flow and ensure that it works as expected (data is collected for 2 users + and 2 keys are minted)

Verification

  • Add a separate address as a verifier
  • Create QR code for one of the valid NFT you own and check in using your phone or laptop camera
  • Check if metadata is displayed when you are a verifier and check-in is persistent from the members' page.

Payments methods

Credit Card flow for Unlock User accounts

  • Open the demo for a lock that has credit card enabled
  • Follow the steps to unlock using a credit card as a new user
  • Make sure unlocking works successfully
  • Connect to the keychain using your Unlock credentials
  • Ensure the key you just purchased is there

Swap & purchase

  • Update the currency for a lock (e.g. USDC) to enable swap & purchase
  • Open the demo for the lock with the updated currency
  • Make sure that swap & purchase is enabled as payment method
  • Use swap and purchase and make sure that unlocking works successfully

Custom credit card price

  • Open settings for a lock and go to payments.
  • Enable custom credit card and set a fixed price
  • Go through the checkout flow and ensure that the custom price correctly shows as the price for the lock
  • Make sure that purchase with custom price works successfully

@cla-bot cla-bot bot added the cla-signed label Jun 18, 2024
@julien51 julien51 requested review from clemsos and SVell June 18, 2024 01:09
@SVell
Copy link
Contributor

SVell commented Jun 18, 2024

On Demo return to Site button doesn't work

@SVell
Copy link
Contributor

SVell commented Jun 18, 2024

And Demo cannot be closed via X button

@SVell
Copy link
Contributor

SVell commented Jun 18, 2024

UI is pretty bad here (RSVP checkout)

image

@SVell
Copy link
Contributor

SVell commented Jun 18, 2024

Swap and purchase worked but only on 2 try

@SVell
Copy link
Contributor

SVell commented Jun 18, 2024

Swap and purchase worked but only on 2 try

Not reproducable

@SVell
Copy link
Contributor

SVell commented Jun 18, 2024

Getting this error from time to time (checkout)

image

@SVell
Copy link
Contributor

SVell commented Jun 18, 2024

Checkout does not have By More button if lock allows multiple keys by address (Demo has this option)
image
image

@SVell
Copy link
Contributor

SVell commented Jun 18, 2024

Checked:

  • Guld hook
  • Discount hook
  • Unlock account sign in, sign up
  • Checkout modifications
  • Cancel and renew keys from keychaion
  • Key airdrop
  • Key cancel and extend from lock screen

@julien51
Copy link
Member Author

julien51 commented Jun 18, 2024

On Demo return to Site button doesn't work
And Demo cannot be closed via X button

I think it might be the same bug. I will try to debug.

EDIT: here is the fix #14065

@julien51
Copy link
Member Author

UI is pretty bad here (RSVP checkout)

image

Agreed it's not ideal but that was not changed.

@julien51
Copy link
Member Author

Getting this error from time to time (checkout)

image

I see multiple errors here. The Decent ones are expected when the route cannot be found.
I am more worried about the EIP-1193 one. Is that the one you are referring to? Any way to reproduce?

@julien51
Copy link
Member Author

Checkout does not have By More button if lock allows multiple keys by address (Demo has this option) image image

Can you share the checkout URL you are using here?

@julien51
Copy link
Member Author

julien51 and others added 3 commits June 18, 2024 10:09
* fix network switch

* remove unwanted console log

* cross-chain parse gas values properly

* recreate provider proplery

* cross chain: delete unwanted gas values
…et connect (#14068)

* use eip1193 to init provider on wallet connect

* clarify provider flow
@julien51 julien51 merged commit c025689 into production Jun 18, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants