Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(unlock-app): fix paywall modal when closed #14065

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fix(unlock-app): fix paywall modal when closed #14065

merged 1 commit into from
Jun 18, 2024

Conversation

julien51
Copy link
Member

Description

This was happening because of a missing prop.

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Jun 18, 2024
@julien51 julien51 requested review from clemsos and SVell June 18, 2024 13:42
@julien51 julien51 mentioned this pull request Jun 18, 2024
Merged
32 tasks
@julien51 julien51 merged commit 96a2879 into master Jun 18, 2024
12 checks passed
@julien51 julien51 deleted the paywall-modal-close-fix branch June 18, 2024 14:08
julien51 added a commit that referenced this pull request Jun 18, 2024
@julien51
fix(unlock-app): fix paywall modal when closed (#14065)
4c2ef01 
fix for paywall modal when closed
julien51 added a commit that referenced this pull request Jun 18, 2024
@julien51 @clemsos
Production Deploy (#14063)
c025689 
* Manual deploy as of commit:2c21135eb2fe5f56bad82c282c07c36ee49b9877

* fix(unlock-app): fixing decent serialization

* fix(unlock-app): fix paywall modal when closed (#14065)

fix for paywall modal when closed

* fix(unlock-app): fix network switch (#14064)

* fix network switch

* remove unwanted console log

* cross-chain parse gas values properly

* recreate provider proplery

* cross chain: delete unwanted gas values

* fix(unlock-app): use eip1193 when recreating wallet provider for wallet connect (#14068)

* use eip1193 to init provider on wallet connect

* clarify provider flow

---------

Co-authored-by: Clément Renaud <clement@unlock-protocol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemsos clemsos Awaiting requested review from clemsos

@SVell SVell Awaiting requested review from SVell

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@julien51