fix(unlock-app): fix network switch #14064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien51
reviewed
Jun 18, 2024
| @@ -96,7 +96,7 @@ export const useProvider = (config: any) => { | |||
| )) as unknown as ethers.BrowserProvider | |||
| } else { | |||
| await switchBrowserProviderNetwork(networkId) | |||
| walletServiceProvider = new ethers.BrowserProvider(pr.provider, 'any') | |||
| walletServiceProvider = new ethers.BrowserProvider(window.ethereum!) | |||
There was a problem hiding this comment.
Are you sure this works with wallet connect or Coinbase wallet?
There was a problem hiding this comment.
for coinbase that approach should work https://docs.cdp.coinbase.com/wallet-sdk/docs/injected-provider/
but fails with WalletConnect indeed
julien51
pushed a commit
that referenced
this pull request
Jun 18, 2024
* fix network switch * remove unwanted console log * cross-chain parse gas values properly * recreate provider proplery * cross chain: delete unwanted gas values
julien51
added a commit
that referenced
this pull request
Jun 18, 2024
* Manual deploy as of commit:2c21135eb2fe5f56bad82c282c07c36ee49b9877 * fix(unlock-app): fixing decent serialization * fix(unlock-app): fix paywall modal when closed (#14065) fix for paywall modal when closed * fix(unlock-app): fix network switch (#14064) * fix network switch * remove unwanted console log * cross-chain parse gas values properly * recreate provider proplery * cross chain: delete unwanted gas values * fix(unlock-app): use eip1193 when recreating wallet provider for wallet connect (#14068) * use eip1193 to init provider on wallet connect * clarify provider flow --------- Co-authored-by: Clément Renaud <clement@unlock-protocol.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make things works properly when prompting to switch network in user web wallet
Issues
Fixes #
Refs #
Checklist:
Release Note Draft Snippet