Wiring up new homepage to new dashboard #281
Conversation
change account to base levelunlock/unlock-app/src/components/creator/Dashboard.js Lines 26 to 31 in b96c624 This comment was generated by todo based on a
|
| render() { | ||
| if (!this.props.account) { | ||
| return null //loading | ||
| } |
There was a problem hiding this comment.
We should probably eventually handle that at a higher level.. But that'll do for now!
| } | ||
|
|
||
| const mapDispatchToProps = dispatch => ({ | ||
| setTransaction: (transaction) => dispatch(setTransaction(transaction)), |
There was a problem hiding this comment.
Are we actually calling this anywhere in the component?
|
|
||
| dashboardClick() { | ||
| this.props.history.push('/dashboard') | ||
| } |
There was a problem hiding this comment.
Hum, I would expect react router to handle that for you?
| @@ -13,7 +23,7 @@ export default class Home extends PureComponent { | |||
| Unlock is a protocol which enables creators to monetize their content with a few lines of code in a fully decentralized way. | |||
| </Headline> | |||
|
|
|||
| <Action> | |||
| <Action onClick={this.dashboardClick}> | |||
| <HomepageButton>Go to Your Dashboard</HomepageButton> | |||
There was a problem hiding this comment.
Same here, you should probably use Link from react-router-dom.
|
Yep, I'm working on the changes! |
|
Using router. PTAL |
| <HomepageButton>Go to Your Dashboard</HomepageButton> | ||
| <ButtonLabel>Requires a browser with an Ethereum wallet</ButtonLabel> | ||
| </Action> | ||
| <Link to={'/dashboard'}> |
There was a problem hiding this comment.
You'll know what I say about nesting components!... but I guess you tried without?
There was a problem hiding this comment.
I did, yeah. I have some feature requests for the next version of styled-components.
| @@ -51,6 +55,10 @@ export default class Home extends PureComponent { | |||
| } | |||
| } | |||
|
|
|||
| Home.propTypes = { | |||
There was a problem hiding this comment.
You can probably get rid of this ;)
No description provided.