Skip to content
This repository has been archived by the owner on Aug 1, 2021. It is now read-only.

Check for allowed licenses #6

Open
hauleth opened this issue Jun 12, 2018 · 8 comments
Open

Check for allowed licenses #6

hauleth opened this issue Jun 12, 2018 · 8 comments

Comments

@hauleth
Copy link
Contributor

hauleth commented Jun 12, 2018

It would be nice to have file like .licenses.exs that would contain list of allowed licenses and list of packages that are explicitly allowed. If there would be incompatible license and that package would be outside allowed scope the task should exit with exit code different from 0.

Such change would allow to integrate this tool into CI pipelines and would allow to provide quick review of dependencies licensing.

@unnawut
Copy link
Owner

unnawut commented Jun 13, 2018

Sounds good! Would you like to take that on, or leave it as a feature request?

@hauleth
Copy link
Contributor Author

hauleth commented Jun 13, 2018

I can try to write such.

@unnawut
Copy link
Owner

unnawut commented Jun 13, 2018

Thanks! Let me know if I can help with anything :)

@unnawut
Copy link
Owner

unnawut commented Jun 13, 2018

I wonder though... since packages don't always have a complete license information, we might need some kind of tolerance level. E.g. what to do if the license couldn't be detected, what if the license defined in mix.exs and LICENSE file are conflicting, etc?

@hauleth
Copy link
Contributor Author

hauleth commented Jun 14, 2018

@unnawut the point of this issue isn't to provide "fit them all" solution that will work always, but to provide users tool that would check if there is no copyleft license in their dependencies by accident.

@joladev
Copy link

joladev commented Sep 8, 2019

I've used a tool like that before https://github.com/frapposelli/wwhrd and that approach worked pretty well (with blacklists, exceptions etc). Covers the "no copyleft" scenario, but gives you a way out with exceptions.

@joladev
Copy link

joladev commented Sep 9, 2019

@unnawut I'll probably need to build that, would you be interested in merging that functionality into licensir or should I use licensir as a dependency?

@unnawut
Copy link
Owner

unnawut commented Sep 9, 2019

Sounds good to me. Since it is going to be your contribution, feel free to make the call on making it a pull request or a new library.

I'll be happy to review & accept the feature if you decide the former. For the latter, I'll be happy to refer to your tool on licensir's readme as well! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants