Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preset-uno): remove extra spaces on grid rules #142

Merged
merged 2 commits into from Nov 19, 2021

Conversation

userquin
Copy link
Member

closes #134

@userquin userquin requested a review from antfu as a code owner November 19, 2021 12:37
@netlify
Copy link

netlify bot commented Nov 19, 2021

✔️ Deploy Preview for ecstatic-mestorf-2e8afd ready!

🔨 Explore the source changes: f70bea7

🔍 Inspect the deploy log: https://app.netlify.com/sites/ecstatic-mestorf-2e8afd/deploys/6197bb01339fe500082a13a5

😎 Browse the preview: https://deploy-preview-142--ecstatic-mestorf-2e8afd.netlify.app

@hannoeru
Copy link
Collaborator

@userquin I think you need to rebuild cli package then update snapshot again to pass the test.

@userquin
Copy link
Member Author

@userquin I think you need to rebuild cli package then update snapshot again to pass the test.

Yeah, I'm building it rn...

@userquin
Copy link
Member Author

@hannoeru can you checkout the branch and update it? I'm getting this error on windows (why pnpm is picking wrong nvm):

C:\Users\userquin>pnpm --version
6.22.2

C:\Users\userquin>node --version
v16.12.0

C:\Users\userquin>nvm list

  * 16.12.0 (Currently using 64-bit executable)
    16.7.0
    15.11.0
    15.5.1
    14.17.6
    12.18.3
    10.16.0
    8.17.0
    8.11.3
    6.12.0
    4.2.4
F:\work\projects\quini\GitHub\antfu\unocss-master>nr build

> @unocss/monorepo@0.11.2 build F:\work\projects\quini\GitHub\antfu\unocss-master
> pnpm -r --filter !playground --filter !fixtures run build && pnpm -r run build-post

node:internal/modules/cjs/loader:927
  throw err;
  ^

Error: Cannot find module 'C:\Users\userquin\AppData\Roaming\Users\userquin\AppData\Roaming\nvm\v15.11.0\pnpm-global\5\node_modules\pnpm\bin\pnpm.cjs'
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:924:15)
    at Function.Module._load (node:internal/modules/cjs/loader:769:27)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:76:12)
    at node:internal/main/run_main_module:17:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}
 ELIFECYCLE  Command failed with exit code 1.

@johannschopplich
Copy link
Collaborator

johannschopplich commented Nov 19, 2021

Something seems off with the test results. The CLI tests output max-width:7xl; – could be a regression from a last feature, what do you think?

Edit: Haven't read the last comment thoroughly. My bad.

@userquin
Copy link
Member Author

it is picking wrong path, it is concatenating twice the location (Users\userquin\AppData\Roaming is twice in the path):

C:\Users\userquin\AppData\Roaming\Users\userquin\AppData\Roaming\nvm\v15.11.0\pnpm-global\5\node_modules\pnpm\bin\pnpm.cjs

@userquin
Copy link
Member Author

I'm checking the configuration...

@johannschopplich
Copy link
Collaborator

@userquin For Windows, you may want to use fnm – a fast and simple Node.js version manager, built in Rust. 🙂

@userquin
Copy link
Member Author

ok, latest pnpm distros have not the same behavior when running install or runinng some script, it seems ~%dp0 returns wrong path when running scripts.

I just change the pnpm.CMD and pnpx.CMD on nvm to point to the right directory for npm dependencies.

@antfu antfu merged commit 9c447bc into main Nov 19, 2021
@antfu antfu deleted the fix/optimize-grid-rules branch November 19, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grid stuff: remove extra spaces on rules
4 participants