Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't set [Min|Max][Width|Height] to NaN #1338

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

Youssef1313
Copy link
Member

GitHub Issue: closes #1336

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other... Please describe:

Description

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@kazo0
Copy link
Collaborator

kazo0 commented Jan 29, 2024

@nickrandolph / @jeromelaban should we backport this or is it fine to go with whatever workaround you have in the wizard?

Apps are broken without a backport!
unoplatform/uno#15291

@nickrandolph
Copy link
Contributor

@nickrandolph / @jeromelaban should we backport this or is it fine to go with whatever workaround you have in the wizard?

We'll apply this change to uno.studio - we have a custom flyout presenter style, so need to set properties accordingly

@kazo0 kazo0 merged commit 5134c3e into unoplatform:master Jan 30, 2024
13 checks passed
@Youssef1313 Youssef1313 deleted the issues/1336 branch January 31, 2024 07:03
@Youssef1313
Copy link
Member Author

@Mergifyio backport release/stable/4.1

Copy link

mergify bot commented Jan 31, 2024

backport release/stable/4.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 31, 2024
jeromelaban added a commit that referenced this pull request Jan 31, 2024
….1/pr-1338

fix: Don't set [Min|Max][Width|Height] to NaN (backport #1338)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MaterialFlyoutPresenterStyle shouldn't set Min/Max Height/Width to NaN
3 participants