Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gallery][Skia.Gtk/Wasm]Infobadge- Type InfoBadge integer value greater than 999, it always shows default value as 999 #1038

Open
sakshi173 opened this issue May 19, 2023 · 4 comments
Assignees
Labels
kind/bug Something isn't working

Comments

@sakshi173
Copy link
Contributor

Current behavior

Uno.Gallery.-.Google.Chrome.2023-05-18.21-58-42.mp4

Expected behavior

The positive integer should display the typed value.

How to reproduce it (as minimally and precisely as possible)

  1. Open Uno Gallery APP
  2. Tap Burger Menu on the left top right.
  3. Tap "Infobadge" from the "UI Component" list.
  4. Type some positive number greater than 999 for example '67545' inside 'Numeric Value' textbox.
  5. Press enter key.
  6. Notice that the default value shows as '999' only instead of '67545'.

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

WebAssembly, Android, iOS, Skia (GTK on Linux/macOS/Windows)

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

@sakshi173 sakshi173 added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. difficulty/tbd labels May 19, 2023
@jeromelaban
Copy link
Member

I think the behavior is expected. Can you take a look at the Xaml Controls gallery app in the Windows Store?

@sakshi173 sakshi173 changed the title Gallery][Skia.Gtk/Wasm]Infobadge- Type InfoBadge integer value greater than 999, it always shows default value as 999 [Gallery][Skia.Gtk/Wasm]Infobadge- Type InfoBadge integer value greater than 999, it always shows default value as 999 May 19, 2023
@silviuo silviuo self-assigned this Sep 13, 2023
@silviuo
Copy link
Contributor

silviuo commented Sep 13, 2023

Hi @jeromelaban

Currently, we're setting a max value of 999 on the Numeric value NumberBox
image

In the WinUI 2 Gallery, they only set the min value of -1
image

If I remove the max value, the box has the same behavior as in WinUI 2 Gallery, where the max int value of 2147483647 is accepted and any value higher is ignored (the NumberBox Value field is no longer automatically overwritten when out of range)

image
image

Should I go ahead and remove the Maximum NumberBox property as a fix?

cc @agneszitte

@jeromelaban
Copy link
Member

jeromelaban commented Sep 14, 2023

@silviuo This would mean that there's a change that was introduced in that control since the import that was made. Can you take a look and see if that 999 value was changed in the original source?

@silviuo
Copy link
Contributor

silviuo commented Sep 14, 2023

@silviuo This would mean that there's a change that was introduced in that control since the import that was made. Can you take a look and see if that 999 value was changed in the original source?

It came as part of this design improvement commit
3cb7807
Line 126

@MartinZikmund MartinZikmund removed triage/untriaged Indicates an issue requires triaging or verification. difficulty/tbd labels Oct 25, 2023
@MartinZikmund MartinZikmund transferred this issue from unoplatform/uno Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants