Skip to content

Commit

Permalink
fix: Properly resubscribe to nested prop changes (#622)
Browse files Browse the repository at this point in the history
* fix: Properly resubscribe to nested prop changes

* chore: whitespace

* chore: whitespace

(cherry picked from commit 8f4a08f)

# Conflicts:
#	src/Uno.Toolkit.RuntimeTests/Tests/NavigationBarTests.cs
  • Loading branch information
kazo0 authored and mergify[bot] committed Jul 31, 2023
1 parent de8a303 commit 4d76dc9
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions src/Uno.Toolkit.RuntimeTests/Tests/NavigationBarTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ public RedNavBarPage()
};
}
}
<<<<<<< HEAD

[TestMethod]
[RequiresFullWindow]
Expand Down Expand Up @@ -274,6 +275,8 @@ private static void AssertNavigationBar(Frame frame)
Assert.IsTrue(renderedNativeNavBar!.Height > 0, "Native toolbar height is not greater than 0");
Assert.IsTrue(renderedNativeNavBar!.Width > 0, "Native toolbar width is not greater than 0");
}
=======
>>>>>>> 8f4a08f (fix: Properly resubscribe to nested prop changes (#622))
#endif

#if __IOS__
Expand Down Expand Up @@ -403,11 +406,15 @@ private static void AssertNavigationBar(Frame frame)
Assert.AreSame(renderedNativeNavItem, presenter.NavigationController.TopViewController.NavigationItem);
Assert.AreSame(renderedNativeNavBar, presenter.NavigationController.NavigationBar);

<<<<<<< HEAD
Assert.IsTrue(renderedNativeNavBar!.Bounds.Height > 0, "Native toolbar height is not greater than 0");
Assert.IsTrue(renderedNativeNavBar!.Bounds.Width > 0, "Native toolbar width is not greater than 0");
}
#endif
#endif
=======

>>>>>>> 8f4a08f (fix: Properly resubscribe to nested prop changes (#622))

private sealed partial class FirstPage : Page
{
Expand Down Expand Up @@ -540,13 +547,18 @@ public static class NavigationBarTestHelper
public static UINavigationItem? GetNativeNavItem(this NavigationBar? navBar) => navBar
?.TryGetRenderer<NavigationBar, NavigationBarNavigationItemRenderer>()
?.Native;
<<<<<<< HEAD

#elif __ANDROID__
public static AndroidX.AppCompat.Widget.Toolbar? GetNativeNavBar(this NavigationBar? navBar) => navBar
?.TryGetRenderer<NavigationBar, NavigationBarRenderer>()
?.Native;
#endif
public static Task<NavigationBar?> NavigateAndGetNavBar<TPage>(this Frame frame) where TPage : Page
=======
#endif
public static async Task<NavigationBar?> NavigateAndGetNavBar<TPage>(this Frame frame) where TPage : Page
>>>>>>> 8f4a08f (fix: Properly resubscribe to nested prop changes (#622))
{
return frame.NavigateAndGetNavBar(typeof(TPage));
}
Expand Down

0 comments on commit 4d76dc9

Please sign in to comment.